Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Config] Add ExprBuilder::ifEmpty()#6922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
weaverryan merged 1 commit intosymfony:masterfromogizanagi:feature/3.2/config/if_empty_expr_builderSep 18, 2016
Merged
[Config] Add ExprBuilder::ifEmpty()#6922
weaverryan merged 1 commit intosymfony:masterfromogizanagi:feature/3.2/config/if_empty_expr_builderSep 18, 2016
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
wouterj commentedAug 28, 2016
Can you please add |
7ef398d tof0fe739CompareContributorAuthor
ogizanagi commentedAug 28, 2016
@wouterj : Added :) |
fabpot added a commit to symfony/symfony that referenced this pull requestAug 31, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[Config] Add ExprBuilder::ifEmpty()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#6922Useful for instance when you don't expect to have a key set in the resolved config if its content is empty:```php$builder = new TreeBuilder();$tree = $builder ->root('matcher') ->children() ->arrayNode('references_to_exclude') ->validate() ->ifEmpty() ->thenUnset() ->end() ->prototype('scalar')->end() ->end() ->end() ->end() ->buildTree();$tree->finalize(['references_to_exclude' => ['foo', 'bar']]);>>> ['references_to_exclude' => ['foo', 'bar']]$tree->finalize(['references_to_exclude' => []]);>>> []```Commits-------4e46f64 [Config] Add ExprBuilder::ifEmpty()
symfony-splitter pushed a commit to symfony/config that referenced this pull requestAug 31, 2016
This PR was merged into the 3.2-dev branch.Discussion----------[Config] Add ExprBuilder::ifEmpty()| Q | A| ------------- | ---| Branch? | master| Bug fix? | no| New feature? | yes| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets || License | MIT| Doc PR |symfony/symfony-docs#6922Useful for instance when you don't expect to have a key set in the resolved config if its content is empty:```php$builder = new TreeBuilder();$tree = $builder ->root('matcher') ->children() ->arrayNode('references_to_exclude') ->validate() ->ifEmpty() ->thenUnset() ->end() ->prototype('scalar')->end() ->end() ->end() ->end() ->buildTree();$tree->finalize(['references_to_exclude' => ['foo', 'bar']]);>>> ['references_to_exclude' => ['foo', 'bar']]$tree->finalize(['references_to_exclude' => []]);>>> []```Commits-------4e46f64 [Config] Add ExprBuilder::ifEmpty()
ContributorAuthor
ogizanagi commentedAug 31, 2016
Code repository PR is now merged :) |
Member
wouterj commentedAug 31, 2016
Cool! Let's merge this one as well then. 👍 |
Member
weaverryan commentedSep 18, 2016
Awesome, thanks Maxime! |
weaverryan added a commit that referenced this pull requestSep 18, 2016
This PR was merged into the master branch.Discussion----------[Config] Add ExprBuilder::ifEmpty()Aftersymfony/symfony#19764Commits-------f0fe739 [WCM][Config] Add ExprBuilder::ifEmpty()
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aftersymfony/symfony#19764