Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Finder] document array use for locations#6917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -82,7 +82,8 @@ directory to use for the search:: | ||
| Search in several locations by chaining calls to | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. this no longer holds true. I propose to merge the code examples (this one and the ones on line 80 & 89): The location is the only mandatory criteria. It tells the finder whichdirectory to use for the search:: $finder->in(__DIR__); // search in several locations $finder->in(array(__DIR__, '/elsewhere')); $finder->in(__DIR__)->in('/elsewhere'); // use wildcard characters (it has to resolve to at least one directory path) $finder->in('src/Symfony/*/*/Resources');Exclude directories from matching with the [...] ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Hmm, it's less readable... Is it ok for you to suggest the 2 options ? See my update :) Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. 👍 for Wouter's suggestion. @mickaelandrieu we're including more code, with short comments to explain them, as we've found that people mostly scan to code-blocks anyways. This is a situation where this isn't ahuge win, because the text between the paragraphs is so short, but I still like. Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Except for one change: // search inside *both* directories$finder->in(array(__DIR__,'/elsewhere'));// same as above$finder->in(__DIR__)->in('/elsewhere'); This is to be clear what calling | ||
| :method:`Symfony\\Component\\Finder\\Finder::in`:: | ||
| $finder->files()->in(array(__DIR__, '/elsewhere')); | ||
| $finder->in(__DIR__)->in('/elsewhere'); | ||
| Use wildcard characters to search in the directories matching a pattern:: | ||