Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DumpFile() third argument is deprecated and doesn't exists anymore in…#6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
mickaelandrieu wants to merge817 commits intosymfony:2.7frommickaelandrieu:patch-4

Conversation

@mickaelandrieu
Copy link
Contributor

@mickaelandrieumickaelandrieu commentedAug 22, 2016
edited
Loading

DumpFile() third argument is deprecated and doesn't exists anymore since3.0.*

weaverryanand others added30 commitsApril 11, 2016 21:14
* 2.7:  Fixing bad conflict fix
* 2.8:  Fixing bad conflict fix
* 2.7:  fix status code in snippet
* 2.8:  fix status code in snippet
Ldap is the new user provider in  Symfony 2.8, so it would be good to mention it in the list of all user providers.
This PR was merged into the 2.8 branch.Discussion----------fix broken mergeCommits-------5ba5224 fix broken merge
The current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.
This PR was submitted for the 3.0 branch but it was merged into the 2.8 branch instead (closessymfony#6509).Discussion----------Update http_kernel_httpkernel_class.rstThe current code generates a Fatal Error. I can see in the HttpKernel Component's documentation that RouterListener needs a $matcher and a RequestStack object as paramers.Commits-------ee94747 Update http_kernel_httpkernel_class.rst
This PR was merged into the 2.8 branch.Discussion----------fix typo| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | >= 2.8I feel in@pborreli's shoesCommits-------1bfe021 fix typo
…hov)This PR was merged into the 2.8 branch.Discussion----------Added ldap to the list of user providers| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.8+| Fixed tickets | n/aLdap is the new user provider in  Symfony 2.8, so it would be good to mention it in the list of all user providers.Commits-------f723ea5 Added ldap to the list of user providers
* 2.7:  remove documentation of not supported "verbose" option value  use port 587 in Amazon SES example  [symfony#6464] Minor tweak  Fix one more occurence of /read  Fix typo  Added possible values for access_decision_manager.strategy
* 2.8:  [symfony#6465] fix newline position  remove documentation of not supported "verbose" option value  Update http_kernel_httpkernel_class.rst  use port 587 in Amazon SES example  fix typo  [symfony#6464] Minor tweak  Fix one more occurence of /read  Fix typo  Added ldap to the list of user providers  Added possible values for access_decision_manager.strategy
* 2.7:  [symfony#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [symfony#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
* 2.8:  [symfony#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [symfony#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
* 2.7:  On line 360 the  header not working  The `$link` argument must be passed as a reference  Fix snippet
* 2.8:  On line 360 the  header not working  The `$link` argument must be passed as a reference  Fix snippet
The CssSelector class does not exists since 2.8. The behavior is now automatic if the content is an XML file.
wouterjand others added13 commitsAugust 17, 2016 11:19
- fix typo from services to service in the first paragraph- fix typo from "if your buildForm" to "of your buildForm"
…erbaldwin)This PR was merged into the 2.8 branch.Discussion----------[PropertyInfo] Add Component Documentation| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | yes (symfony/symfony#15858)| Applies to    | `2.8`, `3.0`| Fixed tickets | N/AThis is still a *work in progress*, but I'd like feedback from anyone regarding structure, grammar and any other improvements while I continue. After speaking with@dunglas, I'm creating a new PR due our branches differing by about 400 commits.Commits-------a0409d7 Update Reference to Service Container Tags78ea4a5 Update PropertyAccess Component Path7b786af Fix Incorrect Indent96b139b Suggested Changescf7a0ea Add PropertyInfo Component Documentation
* 2.7:  Adding details about the Symfony framework as comments  Adjust Application use statement  replacing with index, otherwise these documents are not included in *any* index  Removed the "Learn more" section  Created a "Platform as a Service" section  Minor improvements  Fixed the "make" command  Fixed again the tricky list syntax  Fixed the syntax of the list  Minor fixes  Reword the third step  Added the missing link references  Updated the instructions to build docs locally  Refactore how to get the container in a test  Fixed a reference  Created the main article about "deployment"
* 2.8: (31 commits)  Adding details about the Symfony framework as comments  Adjust Application use statement  replacing with index, otherwise these documents are not included in *any* index  Error in CSRF example code snippet  Added missing reference  Update serializer.rst  Adding missing link reference forsymfony#6877, because someone must have been in a hurry :)  Remove additional backslash  Add a class specificity for SplFileInfo  Update Reference to Service Container Tags  Remove extra quotes from ExprBuilder::thenInvalid() usage  Update PropertyAccess Component Path  Fix Incorrect Indent  Suggested Changes  Add PropertyInfo Component Documentation  missing "`"  added lyrixx to the core team  Remove redundant verb  Removed the "Learn more" section  Created a "Platform as a Service" section  ...
This PR was merged into the 3.0 branch.Discussion----------[FormComponent] Fix typos- fix typo from services to service in the first paragraph- fix typo from "if your buildForm" to "of your buildForm"Commits-------6d282e4 Fix typos
"in_memory" does not exist. This is a just a provider name. The real keyword is "memory"
This PR was submitted for the 3.1 branch but it was merged into the 2.8 branch instead (closessymfony#6892).Discussion----------Update custom_provider.rst"in_memory" does not exist. This is a just a provider name. The real keyword is "memory"Commits-------2d5b420 Update custom_provider.rst
* 2.7:  [symfony#6892] The provider is called `memory`  Fix typos  Update templating.rst  Update templating.rst  Adds bin folder creation instruction  service_container : fix php Definition instance  [Routing] Fix a route path in a routing example  Minor unrelated spacing fixes  Update doctrine.rst
* 2.8:  Update custom_provider.rst  [symfony#6892] The provider is called `memory`  Fix typos  Update templating.rst  Update templating.rst  Adds bin folder creation instruction  service_container : fix php Definition instance  [Routing] Fix a route path in a routing example  Minor unrelated spacing fixes  Update doctrine.rst
@wouterj
Copy link
Member

👍
status: reviewed

I think we should merge this in 2.7, as it's deprecated in 2.3. Documenting deprecated features doesn't make a lot of sense here imo.

(btw, 3.0 has reached eom, so this should not be merged in 3.0).

@mickaelandrieu
Copy link
ContributorAuthor

mickaelandrieu commentedAug 23, 2016
edited
Loading

Hi@wouterj,
if docs remains published and online (regarding the 3.0), we should fix it, right ?
My only interest here is to not publish mistakes, regardless the maintenance status of versions :D

Mickaël

@wouterj
Copy link
Member

My only interest here is to not publish mistakes, regardless the maintenance status of versions :D

That's not something we do in the docs. Eom versions will have eom docs. Otherwise, we end up maintaining all branch versions (even 2.0).

Please note that eom version docs will have a big yellow warning at the top:http://symfony.com/doc/2.3/components/filesystem And the eom versions don't exists in the version checker.

@mickaelandrieu
Copy link
ContributorAuthor

Please note that eom version docs will have a big yellow warning at the top:http://symfony.com/doc/2.3/components/filesystem And the eom versions don't exists in the version checker.

Ok, I believed every "published" versions of docs were maintained (and so on, the others one were discontinued).

Following what you say, the 3.0 should have the "yellow banner" very soon ? Do you want me to edit the branch of this contribution (from 3.0 to 3.1 ?).

Mickaël

@wouterj
Copy link
Member

Following what you say, the 3.0 should have the "yellow banner" very soon ? Do you want me to edit the branch of this contribution (from 3.0 to 3.1 ?).

Yes, I'll push@javiereguiluz to add it when he's back from his holiday ;)

If possible, please rebase and change this PR on 2.7.

@mickaelandrieu
Copy link
ContributorAuthor

mickaelandrieu commentedAug 23, 2016
edited
Loading

arf, wanted to try the new "change base" button ^^

=> PR closed in favor of#6909

@wouterj
Copy link
Member

wouterj commentedAug 23, 2016
edited
Loading

@mickaelandrieu why didn't the edit button work? (just interested, so I know when I can ask new contributors to edit the base branch)

@mickaelandrieu
Copy link
ContributorAuthor

@wouterj hmm I'd say because there is a big difference between 2.7 and 3.0... it's not a rebase button, it's only made a push on a new base, regarless the origin branch of the contribution (I've started on 3.0 so, all commits from 3.0 were added).

The button is fine for another mistake: If I have started my contribution in 2.7 branch and pushed it on 3.0, I can re edit my contribution to select the "good" branch.

@wouterj
Copy link
Member

@mickaelandrieu I think this would be fixed if you rebase your branch locally (git rebase --onto origin/2.7 origin/3.0) and then force push.

mickaelandrieu reacted with thumbs up emoji

wouterj added a commit that referenced this pull requestAug 28, 2016
…s anymore (mickaelandrieu)This PR was merged into the 2.7 branch.Discussion----------DumpFile() third argument is deprecated and doesn't exists anymoresee#6906nl;dr; ``dumpFile()`` third argument is deprecated and removed in 3.x, we shouldn't document it.Commits-------155e48b DumpFile() third argument is deprecated and doesn't exists anymore in 3.x
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

32 participants

@mickaelandrieu@wouterj@carsonbot@weaverryan@a-ast@xabbuh@kgilden@HeahDude@tyx@AchillesKal@chalasr@aerialls@teohhanhui@z38@jdreesen@hason@JonEastman@csarrazi@dsmink@jvasseur@smatyas@rodnaph@OndraM@talitakz@jonny-no1@javiereguiluz@themasch@georgiana-gligor@hvt@zanbaldwin@rendler-denis@asandjivy

[8]ページ先頭

©2009-2025 Movatter.jp