Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added a help note about the __toString() method in User classes#6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@javiereguiluz
Copy link
Member

This partiallyfixes#6463.

@xabbuh
Copy link
Member

👍

Status: Reviewed

@weaverryan
Copy link
Member

@javiereguiluz I don't think you linked the right issue. Why should we add this?

@wouterj
Copy link
Member

@weaverryan correct issue is#6574

I'm still 👎 for the same reasons:

  • You implementUserInterface, so it's never converted to a string.
  • The whole concept of allowing to pass a string, UserInterface or object with __toString() is just too bad to even talk about. I'll submit a WIP PR this week to the code repository to remove this. In sort, all objects used as user just need to implementUserInterface, let's forget about the objects that can be converted to a string.

@weaverryan
Copy link
Member

@wouterj I understand your point... in fact, I understand it so well, that I can't figure out what the bug/problem was in the original#6574 that this was fixing?

@xabbuh
Copy link
Member

So what do you here?

@javiereguiluz
Copy link
MemberAuthor

Closing it because doc voters don't agree with it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@javiereguiluz@xabbuh@weaverryan@wouterj@carsonbot

[8]ページ先頭

©2009-2025 Movatter.jp