Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Routing: add explanation for the "_fragment" parameter#6783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Routing: add explanation for the "_fragment" parameter#6783
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This change looks good to me. But I think we should add a |
Thanks for the review@xabbuh, I added |
| @@ -475,6 +475,13 @@ that are special: each adds a unique piece of functionality inside your applicat | |||
| ``_format`` | |||
| Used to set the request format (:ref:`read more <routing-format-param>`). | |||
| ``_fragment`` | |||
| .. versionadded:: 3.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I know it's a bit verbose, but in Symfony Docs theversionadded directive is used like this:
.. versionadded:: 3.2 The ``_fragment`` parameter was introduced in Symfony 3.2.👍 Status: reviewed |
| @@ -475,6 +475,13 @@ that are special: each adds a unique piece of functionality inside your applicat | |||
| ``_format`` | |||
| Used to set the request format (:ref:`read more <routing-format-param>`). | |||
| ``_fragment`` | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
IMO, this is the wrong place for it, as you won't use_fragment in route patterns.
It should rather be explained in a section nearGenerating URLs with Query Strings
b2b0fdb to7314bdbCompare7314bdb to0791e48Compare@javiereguiluz I updated the |
I've merged your pull request and fixed a syntax error in0a22dda. I think it's a nice idea to also document this in the generating section indeed. Not sure if I would add a new section or just add it to the main section. Feel free to propose another PR doing this. For now, thanks a lot for documenting this nice feature! |
Uh oh!
There was an error while loading.Please reload this page.
Add explanation about this PR:symfony/symfony#12979
Presented inhttp://symfony.com/blog/new-in-symfony-3-2-routing-improvements
I copy-pasted the start of the announcement as the explanation since I couldn't have found a better explanation. I hope that won't be a problem.