Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
do not reference unused interface#6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Insymfony#5993 we removed the refreshUser() method which is no longer requiredwhen implementing the new UserLoaderInterface. Thus, we no longer haveto reference the UserInterface too.
Member
javiereguiluz commentedJun 9, 2016
👍 nice catch and clearly explained. Thanks! |
Member
weaverryan commentedJun 10, 2016
Status: Reviewed |
weaverryan added a commit that referenced this pull requestJun 10, 2016
This PR was merged into the 2.8 branch.Discussion----------do not reference unused interfaceIn#5993 we removed the refreshUser() method which is no longer requiredwhen implementing the new UserLoaderInterface. Thus, we no longer haveto reference the UserInterface too.Commits-------75c545c do not reference unused interface
Member
weaverryan commentedJun 10, 2016
Sorry - was checking on Carson :) Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In#5993 we removed the refreshUser() method which is no longer required
when implementing the new UserLoaderInterface. Thus, we no longer have
to reference the UserInterface too.