Fix binary directory for demo application#6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

BaptisteAmato wants to merge1 commit intosymfony:masterfromBaptisteAmato:patch-1

Closed

Fix binary directory for demo application#6632

BaptisteAmato wants to merge1 commit intosymfony:masterfromBaptisteAmato:patch-1

Conversation

Copy link

BaptisteAmato commentedJun 1, 2016

Hello,

While trying to install the Symfony Demo application following the documentation onhttp://symfony.com/doc/master/book/installation.html#installing-the-symfony-demo-application, I had a problem asphp bin/console server:run does not work.

I understood in#6182 that the demo application uses Symfony 2.8 and therefore usesphp app/console but I also noticed the regression of this PR in68650b8.

This PR fixes this.

Fix binary directory for demo application

097d590

tgalopin reviewed

Jun 1, 2016

View reviewed changes

book/installation.rst

		built-in web server executing the ``phpbin/console server:run`` command. Access
		built-in web server executing the ``phpapp/console server:run`` command. Access
		to the ``http://localhost:8000`` URL in your browser to start using the Symfony
		Demo application.

Copy link

Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest to add a comment (http://docutils.sourceforge.net/docs/user/rst/quickref.html#comments) explaining why we useapp/console, in order to avoid this regression in the future. What do you think@xabbuh ?

Copy link

Contributor

tgalopin commentedJun 1, 2016

Should we wait forsymfony/demo#338 or fix it now and wait for Symfony 3.1 to be used ?

Copy link

Member

xabbuh commentedJun 21, 2016

Assymfony/demo#338 was merged do we still want to make this change?

xabbuh added the needs comments label

Jun 21, 2016

Copy link

Member

javiereguiluz commentedJun 21, 2016

I agree with@xabbuh. Symfony Demo will use Symfony 3.1 starting from the next version.

Copy link

Contributor

tgalopin commentedJun 21, 2016

If the demo works out of the box with 3.1 in the next version, we can definitely close this :) . IMO we have to keep in mind that demo users don't know Symfony though, it has to be certain that they won't have to change anything :) .