Use a better escaping mechanism for data-prototype attr#6609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wouterj merged 1 commit intosymfony:2.3fromjaviereguiluz:patch-5

May 27, 2016

Merged

Use a better escaping mechanism for data-prototype attr#6609

wouterj merged 1 commit intosymfony:2.3fromjaviereguiluz:patch-5

May 27, 2016

Conversation

Copy link

Member

javiereguiluz commentedMay 24, 2016

Twig defines thehtml_attr strategy to escape values to be included in HTML attributes. Let's use it instead of the generic strategy.

Use a better escaping mechanism for data-prototype attr

627e1a0

Copy link

Contributor

HeahDude commentedMay 24, 2016

👍

xabbuh added the Status: Reviewed label

May 24, 2016

Copy link

Member

xabbuh commentedMay 24, 2016

👍 looks reasonable

Copy link

Member

wouterj commentedMay 27, 2016

Thanks Javier.

wouterj merged commit627e1a0 intosymfony:2.3

May 27, 2016

wouterj added a commit that referenced this pull request

May 27, 2016

minor#6609Use a better escaping mechanism for data-prototype attr (…

b841a25

…javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Use a better escaping mechanism for data-prototype attrTwig defines the `html_attr` strategy to escape values to be included in HTML attributes. Let's use it instead of the generic strategy.Commits-------627e1a0 Use a better escaping mechanism for data-prototype attr