Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fixed query_builder option#6596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
xabbuh commentedMay 21, 2016
👍 |
Member
xabbuh commentedMay 21, 2016
You could also update the text to something like this: The value of this option can either be a ``QueryBuilder`` object, a Closure or ``null``. |
ContributorAuthor
HeahDude commentedMay 21, 2016
Ok then#6594 will need a rebase. |
b394ea4 to45f586bCompareContributorAuthor
HeahDude commentedMay 21, 2016
Fixed |
Member
wouterj commentedMay 21, 2016
Thanks Jules! I'm sorry for -1'ing you in#6594, you were 100% correct. |
wouterj added a commit that referenced this pull requestMay 21, 2016
This PR was merged into the 2.3 branch.Discussion----------Fixed query_builder optiondoc fix: 2.3+ref#6594 (comment)Commits-------45f586b Fixed query_builder option
wouterj added a commit that referenced this pull requestMay 21, 2016
Member
wouterj commentedMay 21, 2016
Oh btw, I just made a minor improvement in31de26f |
ContributorAuthor
HeahDude commentedMay 21, 2016
@wouterj 👍 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doc fix: 2.3+
ref#6594 (comment)