Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Clarify signed requests in the ESI renderer#6589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| .. caution:: | ||
| The fragment listener only responds to signed requests. Requests are only | ||
| signed when using fragment renderer and the ``render_esi`` Twig function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] using the fragment [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
By the way, this applies to all renderers extending theAbstractSurrogateFragmentRenderer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, but as this section is about ESI specifically, I only mentionedrender_esi to not make things more complex.
Btw, fixed your other comment.
👍 |
1 similar comment
👍 |
This PR was merged into the 2.3 branch.Discussion----------Clarify signed requests in the ESI rendererI think this clarification makes things more clear to readers. It also explains why something might not work when people don't use the `render_esi` helper function.Commits-------7bad395 Clarify signed requests in the ESI renderer
I think this clarification makes things more clear to readers. It also explains why something might not work when people don't use the
render_esihelper function.