Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fixed an error in the routing chapter#6576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The `$name` variable isn't initiated.
javiereguiluz commentedMay 17, 2016
I'm not sure if this change is really needed. The code that renders templates uses the ob_start();extract($request->query->all(),EXTR_SKIP);// <-- this is where vars are made availableincludesprintf(__DIR__.'/../src/pages/%s.php',$map[$path]);$response =newResponse(ob_get_clean()); |
vanbrabantf commentedMay 17, 2016
I thought the same but when running the code (on windows 10 with PHP7.0.2, not sure if this matters), I do get the Do you want me to share the code provided up to this point in the article (To make it easier to get an overview) ? |
xabbuh commentedMay 19, 2016
It looks like you did forget to include the |
vanbrabantf commentedMay 20, 2016
In the rest of the article there is always a backup, ( If you want I can open another pull request with a catch in it. |
wouterj commentedMay 21, 2016
👍 for adding a default value. |
xabbuh commentedMay 21, 2016
vanbrabantf commentedMay 21, 2016
Ok, great. |
wouterj commentedMay 21, 2016
Thanks for your responses@vanbrabantf. Unfortunately, I'm going to close this one in favor of#6419. I hope to see you back with a PR that we can merge in the future! |
The
$namevariable isn't initiated.