Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Make ClockMock Tests\\ namespace matching less specific#6546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
wouterj commentedMay 13, 2016
Thanks@teohhanhui, it looks great this way! |
…ohhanhui)This PR was merged into the 2.8 branch.Discussion----------Make ClockMock Tests\\ namespace matching less specific| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.8+| Fixed tickets | N/ACommits-------2d8f2ec Make ClockMock Tests\\ namespace matching less specific
…egin with Tests\\ (teohhanhui)This PR was submitted for the 2.8 branch but it was merged into the 3.2-dev branch instead (closes#18726).Discussion----------[PhpUnitBridge] Make ClockMock match namespaces that begin with Tests\\| Q | A| ------------- | ---| Branch? | 2.8| Bug fix? | yes?| New feature? | no| BC breaks? | no?| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR |symfony/symfony-docs#6546See symfony/symfony-standard#969Commits-------2630c13 [PhpUnitBridge] Make ClockMock match namespaces that begin with Tests\\
teohhanhui commentedJun 3, 2016
@wouterj Heads up, the related PRsymfony/symfony#18726 was merged into master (3.2) so perhaps this should be reverted? |
| The ``@group time-sensitive`` works "by convention" and assumes that the | ||
| namespace of the tested class can be obtained just by removing the ``\Tests\`` | ||
| namespace of the tested class can be obtained just by removing the ``Tests\`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@teohhanhui This is the only change that must be revert, right? The fixes below are still valid if I don't miss anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes.
…in with Tests\\ (teohhanhui)This PR was merged into the 3.2-dev branch.Discussion----------[PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\| Q | A| ------------- | ---| Branch? | master| Bug fix? | yes?| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | N/A| License | MIT| Doc PR |symfony/symfony-docs#6546Related to symfony/symfony-standard#969Commits-------d043305 [PhpUnitBridge] Make DnsMock match namespaces that begin with Tests\\
Uh oh!
There was an error while loading.Please reload this page.