Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fix typo: signifcantly => significantly#6483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ifdattic commentedApr 17, 2016
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets |
javiereguiluz commentedApr 17, 2016
👍 |
wouterj commentedApr 18, 2016
Thanks Andrew! |
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#6483).Discussion----------Fix typo: signifcantly => significantly| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Commits-------cfcd8df Fix typo: signifcantly => significantly
wouterj commentedApr 18, 2016
Btw,@javiereguiluz, do you have any idea why your comment shows up as |
javiereguiluz commentedApr 19, 2016
@wouterj 😱 I don't know. I don't remember doing anything different. |
xabbuh commentedApr 19, 2016
@javiereguiluz How do you write your comments? Can this be caused by a saved reply? You can see that your vote is also shown as the icon when you edit your existing comment above. |
javiereguiluz commentedApr 19, 2016
@xabbuh I write |
ifdattic commentedApr 19, 2016
I also think this article could be improved a little bit. It has a small section about fixing performance issues, but in my opinion it's mostly "here take this, go figure it out yourself". Think that it could use the 80/20 approach an be more like "before investing a lot of time try this trick, it works most of the time". If adding that information the biggest question would be in that format: a paragraph of text, a commented out code, or something else. In my opinion that should be noted are:
This video kind of provides the problem and solution (https://www.youtube.com/watch?v=Kn-O4jq0-r4) |