Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Avoid confusion#6472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
gerryvdm wants to merge1 commit intosymfony:3.0fromgerryvdm:patch-4
Closed

Avoid confusion#6472

gerryvdm wants to merge1 commit intosymfony:3.0fromgerryvdm:patch-4

Conversation

@gerryvdm
Copy link

To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all.

Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample.

To me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all.Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample.
@xabbuh
Copy link
Member

👍

weaverryan added a commit that referenced this pull requestApr 26, 2016
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#6472).Discussion----------Avoid confusionTo me it was a bit confusing why the locale was set on the session and not the request. Further more, reading the linked article shows extra code is needed to make this work at all.Since the linked article explains in more detail how to make the locale sticky, I suggest just setting it on the request in this code sample.Commits-------6818b8e Avoid confusion
weaverryan added a commit that referenced this pull requestApr 26, 2016
@weaverryan
Copy link
Member

Wow, I <3 it - it seems much simpler now. Thanks Gerry!

weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.3:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.7:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.8:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 3.0:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gerryvdm@xabbuh@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp