Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fix adding custom extensions for unit testing#6463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix adding custom extensions for unit testing#6463
Uh oh!
There was an error while loading.Please reload this page.
Conversation
xabbuh commentedApr 19, 2016
I am not sure if it wasn't better to properly set up the validator extension here instead of mocking things away. |
xabbuh commentedMay 21, 2016
What do others think about this? |
| ->getMock(); | ||
| $validator | ||
| ->method('getMetadataFor') | ||
| ->will($this->returnValue($metadata)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could actually be->willReturn($metadata);
xabbuh commentedJun 5, 2017
Sorry@natanael89 for not merging your PR earlier. Unfortunately, we merged#7941 in the meantime so there's no need for this PR anymore. I hope to see you soon again with some other changes though. |
The previous version was generating the following error when running tests:
The changes for vesion 2.8+ should be a little different due to the refactoring that took place, but I would be happy to fix it once this gets merged.