Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Testing] Explain how to add or remove data in a collection of forms#6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@alexislefebvre
Copy link
Contributor

QA
Doc fix?no
New docs?no
Applies toall (based on 2.3)
Fixed tickets-

I added a part that explain how to test aCollection of Forms.

HeahDude, fsevestre, and Emmanuellut reacted with thumbs up emoji
@HeahDude
Copy link
Contributor

Great, thanks!

alexislefebvre reacted with thumbs up emoji

@alexislefebvrealexislefebvreforce-pushed thetest-form-with-collection-2.3 branch from37c7ce5 tob645f0eCompareApril 2, 2016 18:28
@alexislefebvrealexislefebvre changed the titleTests: Explain how to add or remove data in a collection of forms[Testing] Explain how to add or remove data in a collection of formsApr 2, 2016
@alexislefebvre
Copy link
ContributorAuthor

alexislefebvre commentedApr 20, 2016
edited
Loading

Can someone please give an opinion on this PR? Thanks.


If you use a:doc:`Collection of Forms</cookbook/form/form_collections>`,
you can't add fields to an existing form with
``$form['task[tags][0][name]'] = 'foo';``, this results in an error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think "this results in [...]" should start a new sentence.

@alexislefebvrealexislefebvreforce-pushed thetest-form-with-collection-2.3 branch fromb645f0e tod820e77CompareApril 21, 2016 21:40
@alexislefebvre
Copy link
ContributorAuthor

@xabbuh Thanks, I followed your advice.

$this->assertEquals(2, $crawler->filter('ul.tags > li')->count());

Where ``task[tags][0][name]`` is the name of a field created
with Javascript.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JavaScript

@xabbuh
Copy link
Member

@alexislefebvre I just left some really minor last comment (we can fix that during merging). Looks good so far. 👍

alexislefebvre reacted with thumbs up emoji

@alexislefebvrealexislefebvreforce-pushed thetest-form-with-collection-2.3 branch fromd820e77 to41276ffCompareApril 23, 2016 14:25
@weaverryanweaverryan merged commit41276ff intosymfony:2.3Apr 26, 2016
weaverryan added a commit that referenced this pull requestApr 26, 2016
…tion of forms (alexislefebvre)This PR was merged into the 2.3 branch.Discussion----------[Testing] Explain how to add or remove data in a collection of forms| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | no| Applies to    | all (based on 2.3)| Fixed tickets | -I added a part that explain how to test a [*Collection of Forms*](http://symfony.com/doc/2.3/cookbook/form/form_collections.html).Commits-------41276ff Tests: Explain how to add or remove data in a collection of forms
weaverryan added a commit that referenced this pull requestApr 26, 2016
@weaverryan
Copy link
Member

This is great - it would be very difficult to figure out :). Thanks@alexislefebvre!

alexislefebvre reacted with hooray emoji

@alexislefebvre
Copy link
ContributorAuthor

Thanks you all! :)

@alexislefebvrealexislefebvre deleted the test-form-with-collection-2.3 branchApril 26, 2016 16:40
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.3:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.7:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 2.8:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
weaverryan added a commit that referenced this pull requestApr 26, 2016
* 3.0:  [#6472] Updating description, after change  Avoid confusion  Added file paths  Fixes and rewords  Documented the config options of TwigBundle  [#6427] Adding a header  Tests: Explain how to add or remove data in a collection of forms  Document constraint validator alias optional
alexislefebvre added a commit to alexislefebvre/symfony-docs that referenced this pull requestApr 2, 2017
xabbuh added a commit that referenced this pull requestApr 8, 2017
This PR was merged into the 2.7 branch.Discussion----------Testing: Fix typo from#6427Fix typo introduced in#6427: `$this->request` → `$request`Commits-------3a9a4f0 Testing: Fix typo from#6427
xabbuh added a commit that referenced this pull requestApr 9, 2017
* 2.7: (48 commits)  docs: choice constraints reference  [#7707] minor tweak  Fixed code block under "Custom Messages"  [#7744] fix XSD locations  Minor XML codes fixes  [#7686] tweak the example code  [#7663] update the PHP example code  Update hostname_pattern.rst  Add missing ";"  Use HTTP instead of http  Fixed indentation in security.rst  Be consistent on service name  Fix missing /  Fix trusted hosts example regular expressions  fixup comment  Testing: Fix typo from#6427  Update apache_router.rst  Update fortrabbit.rst  Fix some YAML codes  Add missing trailing comma & Fix foreach code  ...
xabbuh added a commit that referenced this pull requestApr 13, 2017
* 2.8: (48 commits)  docs: choice constraints reference  [#7707] minor tweak  Fixed code block under "Custom Messages"  [#7744] fix XSD locations  Minor XML codes fixes  [#7686] tweak the example code  [#7663] update the PHP example code  Update hostname_pattern.rst  Add missing ";"  Use HTTP instead of http  Fixed indentation in security.rst  Be consistent on service name  Fix missing /  Fix trusted hosts example regular expressions  fixup comment  Testing: Fix typo from#6427  Update apache_router.rst  Update fortrabbit.rst  Fix some YAML codes  Add missing trailing comma & Fix foreach code  ...
xabbuh added a commit that referenced this pull requestApr 13, 2017
* 3.2: (60 commits)  docs: choice constraints reference  [#7707] minor tweak  Fixed code block under "Custom Messages"  [#7744] fix XSD locations  Minor XML codes fixes  [#7686] tweak the example code  [#7663] update the PHP example code  Update hostname_pattern.rst  Add missing ";"  Use HTTP instead of http  Fixed indentation in security.rst  Be consistent on service name  Fix missing /  typo fix  Fix trusted hosts example regular expressions  add reference built in listener for kernel.response event in >=3.1  fixup comment  Testing: Fix typo from#6427  Update apache_router.rst  Update fortrabbit.rst  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexislefebvre@HeahDude@xabbuh@weaverryan

[8]ページ先頭

©2009-2025 Movatter.jp