Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added tip for optional second parameter for form submissions.#6420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
michaeljoelphillips commentedApr 1, 2016
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | #6415 |
| When submitting a form via a "PATCH" request, you may want to update only a few | ||
| submitted fields. To achieve this, you may pass an optional second boolean | ||
| parameter to ``submit()``. Passing ``false`` will remove any missing fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should beForm::submit().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@HeahDude Shouldn't it be$form->submit(…) instead, as in the example above the tip?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I can't answer that :) I just thought it would be more clear to mention the class involved by that method.
ping @symfony/documentors !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think that's necessary. Above this example we already link to the API docs ofsubmit() twice. That should be clear enough.
HeahDude commentedApr 1, 2016
👍 Looks good |
javiereguiluz commentedApr 1, 2016
Nice tip! Thank you@Nomad145 |
xabbuh commentedApr 1, 2016
👍 |
xabbuh commentedApr 6, 2016
Thank you@Nomad145. |
…ons. (Michael Phillips)This PR was merged into the 2.3 branch.Discussion----------Added tip for optional second parameter for form submissions.| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |#6415Commits-------153219a Added tip for optional second parameter for form submissions.