Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update routing.rst#6419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Update routing.rst#6419
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The change was breaking existing functionality, need to preserve it.
create_framework/routing.rst Outdated
| <!-- example.com/src/pages/hello.php --> | ||
| Hello <?php echo htmlspecialchars($name, ENT_QUOTES, 'UTF-8') ?> | ||
| Hello <?php echo htmlspecialchars(isset($name) ?: 'World', ENT_QUOTES, 'UTF-8') ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't it beisset($name) ? $name : 'World' ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You are right! Thx!
fixed thx to @Ener-Getick
xabbuh commentedMay 21, 2016
👍 |
1 similar comment
javiereguiluz commentedMay 21, 2016
👍 |
xabbuh commentedMay 21, 2016
Thank you@tamtamchik. |
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#6419).Discussion----------Update routing.rst| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | noneThe described version of the file was breaking "default value" functionality, and if user would access this page without `name` variable it'll get warning: `Notice: Undefined variable: name in ../src/pages/hello.php on line 2`Commits-------a29a319 Update routing.rst
The described version of the file was breaking "default value" functionality, and if user would access this page without
namevariable it'll get warning:Notice: Undefined variable: name in ../src/pages/hello.php on line 2