Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added the docs for the @dns-sensitive mocks#6388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| --------------- | ||
| The ``@group time-sensitive`` and ``@group dns-sensitive`` annotations work | ||
| "by convention" and assumes that the namespace of the tested class can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo "assume" ?
@javiereguiluz given that the bridge has more and more features, wouldn't it be better to split its doc into multiple chapters instead, as done for other components ? |
| ~~~~~~~~~~~~~~~ | ||
| DNS-sensitive Tests | ||
| ------------------- | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
missingversionadded
I've changed everything reviewers suggested. I also agree with@stof and we should split this doc as soon as we try to add the explanation of a new feature. |
Ready for the final review before merge. Thanks! |
👍 |
As this PR is adding explanations of new features, I would say it is time 😄 |
@stof I was referring to new explanations after this feature 😁 |
I am 👍 for merging this as is. If someone feels the need to split the component's documentation with this feature set, we can discuss that in a new PR, but don't block merging this one because of a new discussion. |
| DNS-sensitive Tests | ||
| ------------------- | ||
| .. versionadded:: 2.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
.. versionadded:: 3.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed. Thanks!
Thanks for the quick fixes, Javier! |
Thisfixes#6379.