Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Corrected model folder inside bundle#6375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
According to the best practices, I believe that Entity or Document folders should be used.
xabbuh commentedMar 16, 2016
I would not make this change. The term model here refers to classes that are the model of your domain. That's doesn't tell you anything about whether they are mapped to a database using an object-relational mapper or using something like MongoDB (which would be the case when making this change). As a bundle author I even might not care at all if a concrete project maps model objects to MySQL, MongoDB, or a PHPCR backend (see FOSUserBundle for such an example). |
javiereguiluz commentedMar 16, 2016
sfdumi commentedMar 16, 2016
Sounds reasonable. The fact that model could be used without Doctrine slipped me. Thank you,@xabbuh . :) |
wouterj commentedJul 9, 2016
I'm actually not sure why we would document the specific location of domain models: Place them anywhere you think makes much sense would be the best option here imo. Can't we simply remove the "Models" row and add If you agree, can you maybe update this PR,@sfdumi? I know this PR is stalled for a long time. If you don't have the time to work on it anymore, just leave a comment and we'll finish this. |
xabbuh commentedJul 9, 2016
I think I agree with@wouterj. For your own model classes that are not coupled to a specific backend, there are no rules where to store them. Only the location of Doctrine entities and document is important if you do not want to configure all mapping information explicitly. |
According to the best practices, I believe that Entity or Document folders should be used.