Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[book] controller ch review, part 2#6351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
weaverryan added a commit that referenced this pull requestMar 17, 2016
This PR was merged into the 2.3 branch.Discussion----------[book] controller ch review, part 2| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets | noI moved subtitle "The ``Request`` as a Controller Argument" a little bit further down; since it is dealing with the ``Request`` object i think it fits with the subtitle "Managing the Session" since this also deals with the ``Request`` object.Commits-------fdb7bc9 typob56bf19 controller ch review, part 2
| To serve HTML, template needs to be rendered and the content put into | ||
| the ``Response`` object. The shortcut method | ||
| :method:`Symfony\\Bundle\\FrameworkBundle\\Controller\\Controller::render` | ||
| of ``Controller`` class does just that:: |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I like a lot of the ways you re-phrased things, but not this one :). I'm reverting back to the original, which I still think is quite clear.
weaverryan added a commit that referenced this pull requestMar 17, 2016
weaverryan added a commit that referenced this pull requestMar 17, 2016
* 2.3: (24 commits) [#6365] Removing extra : Added minor clarification [#6360] Minor changes [#6349][#6351][#6352] Editing the Doctrine section to improve readability. Minor corrections Fixed typo Fix escaping of backtick inside double back-quotes Removed server:stop code block for 2.3 Removed the PR table example (this is now included by GitHub template) Updated link to Translatable Extension [reference] [constraints] added missing colon character for Image constraint documentation in YAML format. Editing the Doctrine section to improve readability. Removed info about reducing visibility for private Updated link to Translatable Extension Editing the Doctrine section to improve readability. typo controller ch review, part 3 typo controller ch review, part 2 ...
xabbuh added a commit that referenced this pull requestMar 26, 2016
* 2.7: (32 commits) Fixed wrong code examples for Isbn constraint unused use instructions Fix typo in SwitchUserListener file name Changed folder name to lowercase (best practises) [#6365] Removing extra : Add a note about enabling DebugBundle to use VarDumper inside Symfony Update introduction.rst Added minor clarification Changed folder name to lowercase (best practises) Fixed typo in path [#6360] Minor changes [#6349][#6351][#6352] Editing the Doctrine section to improve readability. Minor corrections Fixed typo Fix escaping of backtick inside double back-quotes Removed server:stop code block for 2.3 Removed the PR table example (this is now included by GitHub template) Updated link to Translatable Extension [reference] [constraints] added missing colon character for Image constraint documentation in YAML format. ...Conflicts:book/controller.rst
xabbuh added a commit that referenced this pull requestMar 26, 2016
* 2.8: (37 commits) Fixed wrong code examples for Isbn constraint Calling the parent implementation is mandatory. unused use instructions Fix typo in SwitchUserListener file name Reworded the example about $deep param Changed folder name to lowercase (best practises) [#6365] Removing extra : Add a note about enabling DebugBundle to use VarDumper inside Symfony Update introduction.rst Added minor clarification Changed folder name to lowercase (best practises) Fixed typo in path [#6360] Minor changes [#6349][#6351][#6352] Update "bootstrap.php.cache" to "autoload.php" Editing the Doctrine section to improve readability. Minor corrections Fixed typo Fix escaping of backtick inside double back-quotes Made list of types more consistent ...Conflicts:book/installation.rstbook/testing.rst
xabbuh added a commit that referenced this pull requestMar 26, 2016
* 3.0: (38 commits) Fixed wrong code examples for Isbn constraint Calling the parent implementation is mandatory. unused use instructions Fix typo in SwitchUserListener file name Reworded the example about $deep param Changed folder name to lowercase (best practises) [#6365] Removing extra : Add a note about enabling DebugBundle to use VarDumper inside Symfony Update introduction.rst Added minor clarification Changed folder name to lowercase (best practises) Fixed typo in path [#6360] Minor changes [#6349][#6351][#6352] Update "bootstrap.php.cache" to "autoload.php" Editing the Doctrine section to improve readability. Minor corrections Fixed typo Fix escaping of backtick inside double back-quotes Made list of types more consistent ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved subtitle "The
Requestas a Controller Argument" a little bit further down; since it is dealing with theRequestobject i think it fits with the subtitle "Managing the Session" since this also deals with theRequestobject.