Fix configuration.rst typo#6337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

gong023 wants to merge1 commit intosymfony:3.0fromgong023:patch-1

Closed

Fix configuration.rst typo#6337

gong023 wants to merge1 commit intosymfony:3.0fromgong023:patch-1

Conversation

Copy link

Contributor

Hmm, this is a fun one (if I may say). As a plain "secret" string is not that secret, we replaced the "s" with the dollar sign resulting in$ecret. However, I understand why this can be extremely confusing.

I've merged this PR into the 2.3 branch (which, btw, caused the closed status of this PR instead of merged) and changed it toyour_secret to avoid further confusion. Thanks for reporting this and submitting a possible fix!

wouterj added a commit that referenced this pull request

Mar 7, 2016

minor#6337Fix configuration.rst typo (gong023)

71c6414

This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#6337).Discussion----------Fix configuration.rst typo`$ecret` seems to be typoCommits-------129c707 Fix configuration.rst typo

wouterj added a commit that referenced this pull request

Mar 7, 2016

[#6337] Change value of client_secret option

c63c826

wouterj closed this

Mar 7, 2016

Copy link

ContributorAuthor

gong023 commentedMar 7, 2016

At first I also thought$ecret was a joke. But actually,$secret and$ecret were mixed before I sent this pull request. So I was confused.
Thank you for your reviewing!