Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[HttpFoundation] ParameterBag::get() $deep param#6333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Oliboy50 wants to merge1 commit intosymfony:2.8fromOliboy50:patch-2

Conversation

Oliboy50
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.8+

Documentation replacement for$deep parameter ofParameterBag::get() since it was deprecated in 2.8 and removed in 3.0.

Because there's no need to show the legacy way of doing this. We just get an array back and that's all.

@javiereguiluz
Copy link
Member

👍 I agree completely with you. Thanks@Oliboy50.

I have a minor suggestion though. Don't you think that the original example is a bit confusing because of this:?foo[bar]=bar Thebar string is repeated, so when the example saysreturns 'bar' you don't know if it's returning the key or the value. Maybe we should replace it by?foo[bar]=baz ?

@javiereguiluz
Copy link
Member

@Oliboy50 I've created#6390 to finish this PR. You work was great but we wanted to make a final change. To avoid letting pull requests "die", from time to time we take over pending PRs to finish them. Of course I reused your original commit, so you'll get full credit for your work once this is merged. Thanks!

@Oliboy50
Copy link
ContributorAuthor

thanks,@javiereguiluz I was waiting for a comment on this PR, but I didn't receive a mail for your comment 11days ago... so I though nobody answered it, my bad

anyway, I completely agree with all you said/done, so thanks a lot :)

@Oliboy50Oliboy50 deleted the patch-2 branchMarch 20, 2016 20:04
xabbuh added a commit that referenced this pull requestMar 26, 2016
…guiluz)This PR was merged into the 2.8 branch.Discussion----------Reworded the example about $deep paramThis finishes#6333.Commits-------09bc39e Reworded the example about $deep paramf82b32e [HttpFoundation] ParameterBag::get() $deep param
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Oliboy50@javiereguiluz@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp