Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Update extension.rst - added caution box for people trying to remove the default file with services definitions#6328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@paolo42! I'm afraid I don't really agree with the changes you proposed. This document is explaining how to configure the service container from within a bundle. It doesn't mention the On the other hand, I can imagine people following this guide and extracting their complete AppBundle into a shared bundle. They propably do the same thing as you, remove this file and forget to remove the imports. Before adding this to the document, I would love to hear some opinions of other people/doc maintainers. What we should consider here: Is this problem common enough to document? And is this problem difficult to debug without this mention in the documentation? If we want to document it, I propose to make it smaller. E.g. by adding a little caution box telling"If you removed the |
Hi! I understand. The article doesn't even mention the file, and I could as well just leave it empty. Also, the caution box should be in the end of the article, not the beginning. I think I'll wait a few days for more comments and if nothing happens, I'll |
👍 to add the caution. |
Caution version is here. Feel free to add more comments or close the request. |
| ..caution:: | ||
| If you removed the default file with services definitions (i. e. ``app/config/services.yml``), | ||
| make sure to also remove it from the ``imports`` key in ``app/config/config.yml``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think just before the "Using Configuration to Change the Services" section will be a much better location for this caution (as it's not related to the last section).
Please also note that we count the 72th character from the start of the line (so with indentation spaces included) andi. e. should bei.e..
If you can do these changes, great! Otherwise, they are quite trival so we can make them during the merge process as well.
Thanks for the update,@paolo42! 👍 from me |
…the default file with services definitions
👍 |
Everything should be fine now. Thanks for collaboration. |
…g to remove the default file with services definitions (Pavel Jurecka)This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes#6328).Discussion----------Update extension.rst - added caution box for people trying to remove the default file with services definitionsFollowing steps from the original article isn't enough, because config.yml still tries to import services.yml from the original location.Commits-------8369fe5 Update extension.rst - added caution box for people trying to remove the default file with services definitions
Thank you@paolo42 for this nice improvement. I have merged it into the |
* 2.3: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings
* 2.7: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
* 2.8: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
* 3.0: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos Fix reference to app folder [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
Following steps from the original article isn't enough, because config.yml still tries to import services.yml from the original location.