Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Mention IvoryCKEditorBundle in the Symfony Forms doc#6305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
reference/forms/types/textarea.rst Outdated
| If you prefer to use an **advanced WYSIWYG editor** instead of a plain | ||
| textarea, consider using the `IvoryCKEditorBundle`_ community bundle. Read | ||
| `its documentation</doc/current/bundles/IvoryCKEditorBundle/index.html>`_ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This link looks wrong.
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's correct. However, we always use absolute URLs (including domain name) and we don't inline the links. Can you please update it,@javiereguiluz ?
MemberAuthor
javiereguiluz commentedMar 10, 2016
I've done the recommended changes. Thanks! |
| If you prefer to use an **advanced WYSIWYG editor** instead of a plain | ||
| textarea, consider using the IvoryCKEditorBundle community bundle. Read | ||
| `its documentation<https://symfony.com/doc/current/bundles/IvoryCKEditorBundle/index.html>`_ |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This should be ``its documentation_ and then `.. _its documentation: https://....` at the bottom of the article.
Member
wouterj commentedMar 10, 2016
👍 |
xabbuh added a commit that referenced this pull requestMar 10, 2016
…iereguiluz)This PR was squashed before being merged into the 2.3 branch (closes#6305).Discussion----------Mention IvoryCKEditorBundle in the Symfony Forms docThis is the most obvious mention we can do. If you have other ideas to mention this bundle, please share them. Thanks!Commits-------6126711 Mention IvoryCKEditorBundle in the Symfony Forms doc
xabbuh added a commit that referenced this pull requestMar 10, 2016
Member
xabbuh commentedMar 10, 2016
Thanks Javier, I have merged this and move the link target to the bottom of the file as suggested by Wouter in032b167. |
xabbuh added a commit that referenced this pull requestMar 11, 2016
* 2.3: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings
xabbuh added a commit that referenced this pull requestMar 11, 2016
* 2.7: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh added a commit that referenced this pull requestMar 11, 2016
* 2.8: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
xabbuh added a commit that referenced this pull requestMar 11, 2016
* 3.0: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos Fix reference to app folder [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the most obvious mention we can do. If you have other ideas to mention this bundle, please share them. Thanks!