Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[quick tour] mostly typos#6275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
talitakz commentedFeb 15, 2016
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | x |
| @@ -309,4 +309,4 @@ need to learn a lot to become a Symfony master. Ready to dig into these | |||
| topics now? Look no further - go to the official :doc:`/book/index` and | |||
| pick any topic you want. | |||
| .._Composer: https://getcomposer.org | |||
| .._`Composer`: https://getcomposer.org | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is technically not wrong ... but I prefer this syntax too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The proposed changed is more common throughout the documentation.
I need to find some time to review this as this is really a lot of changes. On the first glance they look good but I need to do some deeper reviewing. I cannot promise when I will have the time to do the review but please feel free to ping me if I forget about it. |
| When you browsed ``http://localhost:8000/app/example``earlier, Symfonyexecuted | ||
| the controller defined in the ``src/AppBundle/Controller/DefaultController.php`` | ||
| If you'd browsed ``http://localhost:8000/app/example``for example, Symfonycould | ||
| executedthe controller defined in the ``src/AppBundle/Controller/DefaultController.php`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
When you go to ``http://localhost:8000/app/example``, Symfony will execute thecontroller in ``src/AppBundle/Controller/DefaultController.php`` and render the ...
👍 once @paxyknox can make the changes mention in the comments. Thanks! |
| @@ -43,7 +44,7 @@ Actions and Controllers | |||
| ~~~~~~~~~~~~~~~~~~~~~~~ | |||
| Open the ``src/AppBundle/Controller/DefaultController.php`` file and you'll | |||
| see the following code (for now, don't look at the ``@Route`` configuration | |||
| see the following code (for now, don't look at the ``@Route()`` configuration | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm -1 on this change, annotations are like classes. We use the() to indicate functions
I made requested changes. |
👍 Thanks for the detailed review and fixes @paxyknox! |
Thank you @paxyknox for this very nice review. I have merged your pull request into the |
* 2.3: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings
* 2.7: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
* 2.8: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform
* 3.0: [#6219] some tweaks Point that route parameters are also Request attributes [#6348] some minor tweaks [best practices] mostly typos Fix reference to app folder [#6275] some minor tweaks [quick tour] mostly typos remove link-local IPv6 address (fe80::1) [#6305] move link reference to the bottom Mention IvoryCKEditorBundle in the Symfony Forms doc [#6328] minor tweak Update extension.rst - added caution box for people trying to remove the default file with services definitions Altered single / multiple inheritance sentence Replace XLIFF number ids by strings Rename DunglasApiBundle to ApiPlatform