Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[Validator] Add warning for null and blank values for minimum string length#6270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Validates that a given string length is *between* some minimum and maximum value. | ||
| **Warning**: *null* and *blank* values are not handled by this constraint. To | ||
| handle them, refers to the:doc:`/reference/constraints/Null`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo here: refer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@xabbuh does this generic warning message is good for you? I would like to agree on the message in one place first before applying it everywhere needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would write it like "null and the empty string are not handled by this constraint. Additionally add theNotBlank orNotNull constraint to exclude these values."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and then we should add it in acaution block
869f904 toef7976bCompare…um string length (theofidry)This PR was submitted for the 2.3 branch but it was merged into the 2.7 branch instead (closes#6270).Discussion----------[Validator] Add warning for null and blank values for minimum string length| Q | A || --- | --- || Doc fix? | yes || New docs? | no || Applies to | 2.3+ || Fixed tickets |symfony/symfony#16157 |Follow up of#5789.Summary of what has been said: even though the [Length#min](http://symfony.com/doc/current/reference/constraints/Length.html#min) option is well detailed and mention the case of `null` values, the introduction is still confusing:> Validates that a given string length is between some minimum and maximum value.As a result, a warning note is being added under this introduction.I've listed all the Symfony constraints. For some this `null` and `blank` values specificity has already been mentioned. I've noted the ones on which this warning does not apply, but for some I am not sure so it needs to be doubled checked.- Basic Contraints - [x] NotBlank: already done - [x] Blank: already done - [x] NotNull: already done - [x] IsNull: already done - ~~[ ] IsTrue~~ - ~~[ ] IsFalse~~ - ~~[ ] Type~~- String Constraints¶ - ~~[ ] Email~~ - [x] Length - ~~[ ] Url~~ - ~~[ ] Regex~~ - ~~[ ] Ip~~ - ~~[ ] Uuid~~- Number Constraints¶ - [ ] Range- Comparison Constraints¶ - ~~[ ] EqualTo~~ - ~~[ ] NotEqualTo~~ - ~~[ ] IdenticalTo~~ - ~~[ ] NotIdenticalTo~~ - [ ] LessThan: needed? How `@Assert\LessThan("-18 years")` behaves if the value is null? - [ ] LessThanOrEqual: same as `LessThan` - [ ] GreaterThan: same as `LessThan` - [ ] GreaterThanOrEqual: same as `LessThan`- Date Constraints¶ - ~~[ ] Date~~ - ~~[ ] DateTime~~ - ~~[ ] Time~~- Collection Constraints¶ - ~~[ ] Choice~~ - ~~[ ] Collection~~ - ~~[ ] Count~~ - ~~[ ] UniqueEntity~~ - ~~[ ] Language~~ - ~~[ ] Locale~~ - ~~[ ] Country~~- File Constraints¶ - ~~[ ] File~~ - ~~[ ] Image~~- Financial and other Number Constraints¶ - ~~[ ] Bic~~ - ~~[ ] CardScheme~~ - ~~[ ] Currency~~ - ~~[ ] Luhn~~ - ~~[ ] Iban~~ - ~~[ ] Isbn~~ - ~~[ ] Issn~~- Other Constraints¶ - ~~[ ] Callback~~ - ~~[ ] Expression~~ - ~~[ ] All~~ - ~~[ ] UserPassword~~ - ~~[ ] Valid~~Commits-------38d44c2 [Validator] Add warning for null and blank values for minimum string length
weaverryan commentedSep 24, 2017
Thanks@theofidry! I've made the final changes. And yes I believe this problem extends also to |
Follow up of#5789.
Summary of what has been said: even though theLength#min option is well detailed and mention the case of
nullvalues, the introduction is still confusing:As a result, a warning note is being added under this introduction.
I've listed all the Symfony constraints. For some this
nullandblankvalues specificity has already been mentioned. I've noted the ones on which this warning does not apply, but for some I am not sure so it needs to be doubled checked.[ ] IsTrue[ ] IsFalse[ ] Type[ ] Email[ ] Url[ ] Regex[ ] Ip[ ] Uuid[ ] EqualTo[ ] NotEqualTo[ ] IdenticalTo[ ] NotIdenticalTo@Assert\LessThan("-18 years")behaves if the value is null?LessThanLessThanLessThan[ ] Date[ ] DateTime[ ] Time[ ] Choice[ ] Collection[ ] Count[ ] UniqueEntity[ ] Language[ ] Locale[ ] Country[ ] File[ ] Image[ ] Bic[ ] CardScheme[ ] Currency[ ] Luhn[ ] Iban[ ] Isbn[ ] Issn[ ] Callback[ ] Expression[ ] All[ ] UserPassword[ ] Valid