Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Cookbook][Bundles]fix yaml syntax#6269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
xabbuh merged 1 commit intosymfony:2.3frommhor:patch-1
Feb 15, 2016
Merged

Conversation

@mhor
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies toall

@mhormhor changed the titlefix yaml syntax[Cookbook][Bundles]fix yaml syntaxFeb 13, 2016
@wouterj
Copy link
Member

👍

1 similar comment
@javiereguiluz
Copy link
Member

👍

@xabbuh
Copy link
Member

Technically, the YAML syntax was valid before, but we need this change so that Sphinx renders the code block successfully. However, the code block will still be rendered without any syntax highlighting as the code block type istext. So I think we should either abstain from making this change or also change the code block type toyaml.

@mhor
Copy link
ContributorAuthor

@xabbuh, I changed block type toyaml. This yaml is technically invalid seehttps://github.com/symfony/symfony-standard/issues/426

@xabbuh
Copy link
Member

👍

Regarding the syntax, I think I will have to read the spec again and maybe we need to fix the Yaml component in regard of how to treat indicator characters. Thanks for pointing that out@mhor.

@xabbuh
Copy link
Member

Thinking about this again, I think we should change the type of the code block back to text as the output that you see in your terminal won't be coloured either.

| Q                | A| --------------- | ----| Doc fix?      | yes| New docs? | no| Applies to   | all
@mhor
Copy link
ContributorAuthor

I agree with you@xabbuh. I revert modification ofcode-block

@xabbuh
Copy link
Member

Thank you@mhor.

@xabbuhxabbuh merged commitd25a312 intosymfony:2.3Feb 15, 2016
xabbuh added a commit that referenced this pull requestFeb 15, 2016
This PR was merged into the 2.3 branch.Discussion----------[Cookbook][Bundles]fix yaml syntax| Q                | A| --------------- | ----| Doc fix?      | yes| New docs? | no| Applies to   | allCommits-------d25a312 fix yaml syntax
@mhormhor deleted the patch-1 branchFebruary 15, 2016 21:45
fabpot added a commit to symfony/symfony that referenced this pull requestFeb 18, 2016
…ers (xabbuh)This PR was merged into the 3.1-dev branch.Discussion----------[Yaml] deprecate starting plain scalars with % characters| Q             | A| ------------- | ---| Bug fix?      | no| New feature?  | no| BC breaks?    | no| Deprecations? | yes| Tests pass?   | yes| Fixed tickets |symfony/symfony-docs#6269, symfony/symfony-standard#426| License       | MIT| Doc PR        |Commits-------e883a4c deprecate starting plain scalars with % characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhor@wouterj@javiereguiluz@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp