Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
[DX] Form Types location contradicts Best Practices#6266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I wondered why I always put form definitions in `AppBundle/Form/Type`, and whether we were meant to put something else in `AppBundle/Form`. While Googling for an answer I came acrosshttp://symfony.com/doc/current/best_practices/forms.html which says the new best practice is to put the form types (which I guess are usually form definitions) directly in `AppBundle/Form`.This PR updates the [main documentation ](http://symfony.com/doc/current/book/forms.html#book-form-creating-form-classes) to reflect the best practices. If anyone can point me to discussions clarifying the difference between form types, form definitions and how the Symfony view has changed (reflected in the change of location) I'd greatly appreciate it.
👍 |
Hi@pbowyer! First of all: 👍 I like this a lot. However, we have to merge changes in the oldest branch and then merge them up into the newer ones. As there has been a lot of form refactorings between 2.3 (oldest) and 3.0 (your current branch), I can't make a nice merge. If possible, can you please redo these changes against the 2.3 version of the docs? (if it's not possible, just comment and we'll do it for you) Then to answer your question: There is no difference between form types and form definitions in Symfony. Each form consists of a root form type, which has children. The children can have children as well, etc. So each field is the end of a branch of this form tree, where node is a form type. This has some big benefits, one of these is that you can reuse "form definitions" in other forms. So an The discussion about the location change can be found here:#6059 |
You can also havetransformers ( That being said, I agree with@weaverryan comment. But the cookbook needs to be updated as well. |
Hi@wouterj,
I've made the changeshere, but couldn't work out how to get them into the |
Hi@pbowyer. I'm very sorry to have completely ignored you to this moment. Can you maybe create a new pull request with that branch against 2.3? We'll close this one then and things can be merged. Thanks for your work! |
I wondered why I always put form definitions in
AppBundle/Form/Type, and whether we were meant to put something else inAppBundle/Form. While Googling for an answer I came across theForms Best Practice guide, which says the new best practice is to put the form types (which I guess are usually form definitions, so the change makes sense) directly inAppBundle/Form.This PR updates themain documentation to reflect the best practices. If anyone can point me to discussions clarifying the difference between form types, form definitions and how the Symfony view has changed (reflected in the change of location) I'd greatly appreciate it.