symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

Fixed code example#6256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

twifty wants to merge2 commits intosymfony:masterfromtwifty:master

Closed

Fixed code example#6256

twifty wants to merge2 commits intosymfony:masterfromtwifty:master

Conversation

Copy link

twifty commentedFeb 10, 2016

The new subscriber must be called after the default listener. The default sets the locale as

$locale =$request->attributes->get('_locale');$request->setLocale($locale);

which overwrites any local set before it.

Fixed code example

83cb682

The new subscriber must be called after the default listener. The default sets the locale as````php$locale = $request->attributes->get('_locale');$request->setLocale($locale);````which overwrites any local set before it.

wouterj reviewed

Feb 10, 2016

View reviewed changes

cookbook/session/locale_sticky_session.rst Outdated

		// must be registeredbefore the default Locale listener
		KernelEvents::REQUEST => array(array('onKernelRequest',17)),
		// must be registeredafter the default Locale listener
		KernelEvents::REQUEST => array(array('onKernelRequest',16)),

Copy link

Member

wouterjFeb 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

let's use 15 to be sure that it's executed after (the default listener is on 16)

wouterj added the Status: Reviewed label

Feb 10, 2016

Copy link

Member

wouterj commentedFeb 10, 2016

👍 Seems 100% valid to me, thanks for submitting the fix!

Changed priority

1447a93

Copy link

Member

javiereguiluz commentedFeb 12, 2016

👍

Copy link

Member

xabbuh commentedFeb 12, 2016

Good catch, thanks@twifty.

xabbuh added a commit that referenced this pull request

Feb 12, 2016

minor#6256Fixed code example (twifty)

8d72a1f

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#6256).Discussion----------Fixed code exampleThe new subscriber must be called after the default listener. The default sets the locale as````php$locale = $request->attributes->get('_locale');$request->setLocale($locale);````which overwrites any local set before it.Commits-------50bca94 Fixed code example

xabbuh closed this

Feb 12, 2016