Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Added comment about SVG height property#6128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedJan 11, 2016
@Nyholm thanks for this contribution. However, I'd consider this a web profiler bug. In the toolbar the height/widthis limited to 24px. So I don't understand why it looks bad in the toolbar. Meanwhile, the profiler menu doesn't limit the height of the icons, so that's the main bug in my opinion. |
Nyholm commentedJan 11, 2016
Yeah, I agree it is a bug. It has been there for a good while (before the redesign). Do you think I should close this PR and open an issue at WebProfiler repo instead? |
javiereguiluz commentedJan 11, 2016
Yes, I think that opening an issue to fix the underlying bug is the way to go here. Thanks! |
javiereguiluz commentedJan 11, 2016
We can close this issue because it's been reported in the code repo (symfony/symfony#17329) and a solution has already been provided (symfony/symfony#17330). |
When you use a .svg file for the toolbar icon it must have
height="24"or the toolbar will render strangely. The attached images will show an example of this render error.