Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
mention routing from the database#6021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@ParamConverter should be enclosed with double backticks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
dupuchba commentedDec 16, 2015
nice :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You also need to add a reference to/cookbook/routing/map.rst.inc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
done
dbu commentedJan 4, 2016
i updated to all the feedback. anything left to do? |
dbu commentedFeb 16, 2016
ping@weaverryan is there a reason to not merge this? happy to correct things if you can tell me what i should change. |
This PR was merged into the 2.3 branch.Discussion----------mention routing from the database| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | 2.3+| Fixed tickets |#2186, relates to#5709if we merge#6020, we might want to put this as subsection of the extending_routing sectionCommits-------c458431 mention routing from the database
weaverryan commentedFeb 16, 2016
@dbu no reason at all - sorry for the delay :) |
if we merge#6020, we might want to put this as subsection of the extending_routing section