symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

mention CMF ChainRouter, restructure documentation for extending routing#6020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

dbu wants to merge1 commit intosymfony:2.3fromdbu:custom-router

Closed

mention CMF ChainRouter, restructure documentation for extending routing#6020

dbu wants to merge1 commit intosymfony:2.3fromdbu:custom-router

Conversation

Copy link

Contributor

dbu commentedDec 16, 2015

Q	A
Doc fix?	no
New docs?	yes
Applies to	2.3+
Fixed tickets	Relates to#5709

dbu reviewed

Dec 16, 2015

View reviewed changes

cookbook/routing/index.rst

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

not sure if its ok to add multiple levels of navigation here, but i think it would make sense. also not sure if this is the right syntax for rst.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This doesn't work in the table of contents. You will probably want to update/cookbook/routing/map.rst.inc instead. But I am not sure if the symfony.com theme is able to render that properly (the platform.sh preview will tell us though).

Copy link

ContributorAuthor

dbuDec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

there is no /cookbook/routing/map.rst.inc file i think. do you have an idea how we should do this? or should we give up on making this a sub-group and just cram it into one article? or a series that repeat part of the title: "Extending Routing: ..."?

Copy link

Member

xabbuhDec 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh sorry about that. :( The right file is/cookbook/map.rst.inc.

Copy link

ContributorAuthor

dbuDec 18, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

yep, found it :-)but we need to solve the general question how we organize theinformation, whether we compact that into one article or something else.

This was referencedDec 16, 2015

mention routing from the database#6021

Merged

extended routing cookbook article#5709

Closed

wouterj reviewed

Dec 17, 2015

View reviewed changes

cookbook/routing/multiple_routers.rst Outdated

Copy link

Member

wouterjDec 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

custom router?

Copy link

Member

wouterj commentedDec 17, 2015

While I think it's good to write a short section about this, we have to make sure to not duplicate much from the CMF docs. The CMF Routing docs already suffer a lot from duplication (bundles, components & quick tour). Adding yet another one would make things hard to maintain.

Copy link

ContributorAuthor

dbu commentedDec 18, 2015

agreed that we should not duplicate this here. the idea is to really just showcase what dynamic router does and then link to the cmf documentation.

mention CMF ChainRouter, restructure documentation for extending routing

541e924

Copy link

ContributorAuthor

dbu commentedJan 4, 2016

any input on where to put the new sections in the navigation? should i put extending_routing, custom_route_loader and multiple_routers all into one page? or just list the 3 on one level? or add another level or hierarchy?

Copy link

ContributorAuthor

dbu commentedFeb 16, 2016

ping@weaverryan
would be glad to wrap this up. meanwhile this is in conflict with upstream - i will rebase and solve the conflicts once we decided how to handle this one. could you give some inputs on the questions above?

weaverryan added a commit that referenced this pull request

Feb 16, 2016

feature#6021mention routing from the database (dbu)

8e36327

This PR was merged into the 2.3 branch.Discussion----------mention routing from the database| Q             | A| ------------- | ---| Doc fix?      | no| New docs?     | yes| Applies to    | 2.3+| Fixed tickets |#2186, relates to#5709if we merge#6020, we might want to put this as subsection of the extending_routing sectionCommits-------c458431 mention routing from the database

Copy link

Member

xabbuh commentedFeb 18, 2016

I think "extending routing" and "custom route loader" could share one document while "multiple routers" better fits in its own article.

weaverryan reviewed

Feb 21, 2016

View reviewed changes

cookbook/routing/extending_routing.rst

		process, e.g. JmsI18nRoutingBundle_.

		.. _FrameworkExtraBundle: https://symfony.com/doc/current/bundles/SensioFrameworkExtraBundle/annotations/converters.html
		.. _JMSI18nRoutingBundle: https://github.com/schmittjoh/JMSI18nRoutingBundle

Copy link

Member

weaverryanFeb 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think we should link here:http://jmsyst.com/bundles/JMSI18nRoutingBundle - the GitHub page just points you there.

Copy link

Member

weaverryan commentedFeb 21, 2016

Sorry for the delay@dbu! I think we should:

not do extending_routing at all - if we want, add more articles to the routing cookbook section to answer questions
keep "custom route loader" and the new "multiple routers" at the top level.

Overall, I really feel that having a lot of top-level "How do I do X" is useful.

Cheers!

xabbuh added Routing Status: Needs Work labels

May 21, 2016

javiereguiluz mentioned this pull request

Feb 14, 2017

Added a mention to ChainRouter from Symfony CMF#7488

Merged

Copy link

Member

javiereguiluz commentedFeb 14, 2017

I'm closing this as "fixed" because:

As pointed by Wouter, we don't want to add docs that are duplicated from other projects;
We already have an article for SymfonyCMF DynamicRouter inhttp://symfony.com/doc/current/routing/routing_from_database.html
InAdded a mention to ChainRouter from Symfony CMF #7488 I've added a mention to ChainRouter, which was the last missing mention.

javiereguiluz closed this

Feb 14, 2017

xabbuh added a commit that referenced this pull request

Mar 7, 2017

minor#7488Added a mention to ChainRouter from Symfony CMF (javiereg…

25bf17b

…uiluz)This PR was merged into the 2.7 branch.Discussion----------Added a mention to ChainRouter from Symfony CMFThis replaces#6020 to complete the mentions to Symfony CMF routers.Commits-------63213a7 Added a mention to ChainRouter from Symfony CMF

dbu deleted the custom-router branch

October 18, 2018 17:26

Labels

Routing Status: Needs Work

5 participants

Movatterモバイル変換

Uh oh!

mention CMF ChainRouter, restructure documentation for extending routing#6020

mention CMF ChainRouter, restructure documentation for extending routing#6020

Uh oh!

Conversation

dbu commentedDec 16, 2015

Uh oh!

dbuDec 16, 2015

Choose a reason for hiding this comment

Uh oh!

xabbuhDec 17, 2015

Choose a reason for hiding this comment

Uh oh!

dbuDec 18, 2015

Choose a reason for hiding this comment

Uh oh!

xabbuhDec 18, 2015

Choose a reason for hiding this comment

Uh oh!

dbuDec 18, 2015 via email

Choose a reason for hiding this comment

Uh oh!

wouterjDec 17, 2015

Choose a reason for hiding this comment

Uh oh!

wouterj commentedDec 17, 2015

Uh oh!

dbu commentedDec 18, 2015

Uh oh!

dbu commentedJan 4, 2016

Uh oh!

dbu commentedFeb 16, 2016

Uh oh!

xabbuh commentedFeb 18, 2016

Uh oh!

weaverryanFeb 21, 2016

Choose a reason for hiding this comment

Uh oh!

weaverryan commentedFeb 21, 2016

Uh oh!

javiereguiluz commentedFeb 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants