Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Updated csrf_in_login_form.rst to include new labels#5942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…n_generatorUpdated CSRF documentation to rename intention and csrf_provider. They were renamed in SF 3.0 to csrf_token_id and csrf_token_generator.
stof commentedDec 1, 2015
the csrf_provider change is also done in 2.8 (deprecating the old one). Otherwise, it would not have matched our upgrade policy |
stof commentedDec 1, 2015
and the change should be done in the 2.8 branch actually, to avoid using the deprecated names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
no need for such comment. this is why we have a versionned doc. Just put aversionadded section saying that the name has changed in 2.8
xabbuh commentedDec 1, 2015
We can add something like the following below the configuration block: ..versionadded::2.8 The ``intention`` and ``csrf_token_generator`` options were introduced in Symfony 2.8. Prior, you had to use the ``csrf_token_id`` and ``csrf_provider`` options. @Raistlfiren You can make the changes here. We should be able to safely backport the PR to the |
GuGuss commentedDec 2, 2015
Need a new commit to rebuild this PR on Platform.sh. |
ogizanagi commentedDec 10, 2015
The SecurityBundle configuration reference should also be updated:http://symfony.com/doc/2.8/reference/configuration/security.html |
ghost commentedDec 10, 2015
I was a little bit confused while upgrading to Symfony 3.0. |
javiereguiluz commentedDec 16, 2015
We're getting more and more reports from users suffering this issue while upgrading to 3.0. Let me know if we can help you in any way to get this merged soon. Thanks! |
xabbuh commentedJan 15, 2016
Thank you@Raistlfiren for starting this. I have taken your changes and finished them in#6152. That's why I close here. However, you will still get the full credit for your contribution as I kept all your commits. |
…lfiren, Aaron Valandra, xabbuh)This PR was merged into the 2.7 branch.Discussion----------csrf_token_generator and csrf_token_id documentation| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes (symfony/symfony#6554,symfony/symfony#9587)| Applies to | 2.4+| Fixed tickets |#3059,#5942Commits-------304d7a5 finish csrf_token_generator and csrf_token_id docs3ceb61c Improper markdown for versionadded.91b5e2e Updated documentation as requested by@stof and@xabbuh0044aa2 Updated csrf_in_login_form.rst to include csrf_token_id and csrf_token_generator
Updated CSRF documentation to rename intention and csrf_provider. They were renamed in SF 3.0 to csrf_token_id and csrf_token_generator. In SF 2.8 intention is depreciated and in SF 2.8 csrf_provider is still being used.