Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix for #5783#5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
BenjaminPaap wants to merge1 commit intosymfony:2.8fromBenjaminPaap:2.8
Closed

Fix for #5783#5796

BenjaminPaap wants to merge1 commit intosymfony:2.8fromBenjaminPaap:2.8

Conversation

@BenjaminPaap
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.8
Fixed tickets#5783

I can confirm, that this is the only place where theSplStorageObject and its methods which were marked as deprecated insymfony/symfony#15907 are referenced.

I can confirm, that this is the only place where the `SplStorageObject`and its methods are referenced.
@xabbuh
Copy link
Member

Great 👍 Perfect pull request@BenjaminPaap! :)

@xabbuh
Copy link
Member

@javiereguiluz@wouterj@weaverryan I would like to merge this into the2.3 branch. Using the methods inherited from theSplObjectStorage never was a good idea and I think we should not describe bad practices in any of our versions. What do you think?

@weaverryan
Copy link
Member

👍

@xabbuh
Copy link
Member

Thank you Benjamin.

xabbuh added a commit that referenced this pull requestOct 19, 2015
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#5796).Discussion----------Fix for#5783| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.8| Fixed tickets |#5783I can confirm, that this is the only place where the `SplStorageObject` and its methods which were marked as deprecated insymfony/symfony#15907 are referenced.Commits-------065d28c Fix for#5783
@xabbuhxabbuh closed thisOct 19, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BenjaminPaap@xabbuh@weaverryan
[8]ページ先頭
©2009-2025 Movatter.jp