Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Update example for method requirements#5776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The example was not doing what the text said it did, as it did not have two routes with the same url but different methods. Updated all four examples (annotations, yaml, xml and php)
OskarStark commentedOct 12, 2015
This is a duplicate, a PR with this code change already exists... let me have a look.... |
OskarStark commentedOct 12, 2015
It has something in common with#5201, but in a reverse way 😄 |
carlos-granados commentedOct 12, 2015
OK, I see that in 2.3 this was changed from something similar to what I am suggesting to the current example. I see in the comments of that PR that this was done to give an example of a route that accepted several methods. I agree this is OK, but then you would need to change the text associated with this example, because what it describes is not what you see in the example. Let me try to change the text so that the explanation and the example say the same thing and I will submit a new commit |
carlos-granados commentedOct 12, 2015
Probably I will better send a new PR, I am closing this one |
The example was not doing what the text said it did, as it did not have two routes with the same url but different methods. Updated all four examples (annotations, yaml, xml and php)