Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Document the support of Mintty for colors#5726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
stof commentedSep 26, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yessymfony/symfony#15915 |
| Applies to | 2.8+ (or 2.3+ depending on where it gets merged) |
| Fixed tickets | n/a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm, this sentence is actually related to the PHPUnit color support. This means it depends onsebastianbergmann/environment#11 rather than on the Symfony PR (PHPUnit does not use the Console component)
xabbuh commentedSep 27, 2015
👍 |
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#15915).Discussion----------Detect Mintty for color support on Windows| Q | A| ------------- | ---| Bug fix? | yes| New feature? | no| BC breaks? | no| Deprecations? | no| Tests pass? | yes| Fixed tickets | n/a| License | MIT| Doc PR |symfony/symfony-docs#5726Mintty is now the default terminal in GitBash, and it supports ANSI colors without the need of ANSICON (it even supports 256 colors rather than the 16 colors supported by ANSICON).I submitted it to 2.8 as it can be considered as a new feature. But it should not be hard to merge it in other branches if we decide to consider it as a bugfix (it just needs to be split because VarDumper does not exist in 2.3)Commits-------12743d1 Detect Mintty for color support on Windows
stof commentedSep 27, 2015
The code has actually been merged in the 2.3 branch, so this now applies to 2.3+ |
xabbuh commentedSep 29, 2015
@stof Should we wait here untilsebastianbergmann/environment#11 gets merged or split this into two pull requests? |
stof commentedSep 29, 2015
Well, actually, you already get colors when running tests in Mintty now if you use the |
xabbuh commentedOct 3, 2015
Thank you@stof. |
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#5726).Discussion----------Document the support of Mintty for colors| Q | A| ------------- | ---| Doc fix? | no| New docs? | yessymfony/symfony#15915| Applies to | 2.8+ (or 2.3+ depending on where it gets merged)| Fixed tickets | n/aCommits-------d8d4345 Document the support of Mintty for colors