Update routing.rst#5659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

ycklsr wants to merge1 commit intosymfony:2.3fromycklsr:patch-1

Closed

Update routing.rst#5659

ycklsr wants to merge1 commit intosymfony:2.3fromycklsr:patch-1

Conversation

Copy link

ycklsr commentedAug 26, 2015

The example code wasn't matching the proposed use-case, i.e establish a strict distinction between GET and POST requests for the very same route.

Update routing.rst

79d1bde

The example code wasn't matching the proposed use-case, i.e establish a strict distinction between GET and POST requests for the very same route.

Copy link

Member

xabbuh commentedAug 26, 2015

Thanks for noticing this issue and providing a PR@Gwad. Actually, we are discussing this issue in#5583. Maybe you want to comment their too with your opinion.

xabbuh added the On hold label

Sep 29, 2015

xabbuh mentioned this pull request

Oct 20, 2015

Fix text for the Method Requirement example#5779

Closed

wouterj mentioned this pull request

Dec 21, 2015

Update HTTP method requirement example#6062

Merged

Copy link

Member

wouterj commentedDec 21, 2015

Hi@Gwad. Thank you for trying to fix & improve the docs and participating in the discussion!

Unfortunately, I'm going to close this PR in favor of#6062 , which rewrites this section to use an API (APIs are already introduced earlier in the Book). 🎄

wouterj closed this

Dec 21, 2015

xabbuh added a commit that referenced this pull request

Jan 11, 2016

minor#6062Update HTTP method requirement example (WouterJ)

7dff788

This PR was merged into the 2.3 branch.Discussion----------Update HTTP method requirement example| Q | A| --- | ---| Doc fix? | yes| New docs? | no| Applies to | 2.3+| Fixed tickets |#5583After many reports (#5779,#5659) of the text no longer matching the example, I think it's time to update the example.The example now uses an API, which is a very common thing now and often needs this feature. API's are already used in the Page Creation article, which is placed before this article, so it shouldn't be too hard to understand.I know that from a REST prespective, HEAD and GET using the same action doesn't seem that great, but it's the only action I could think of that may support 2 methods.Commits-------30c2750 Update method requirement example