Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fix minor problems in book/page_creation.rst#5635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
fabschurt commentedAug 18, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | >= 2.6 |
| Fixed tickets | N/A |
book/page_creation.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't we enclose "if you need to query database" with commas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I don't think so, it's just a list. However, I find this sentence very hard to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@wouterj Yes, me too. Maybe it would be more readable by putting it like that? :
Then, in the Symfony Book, learn about the service container, the form system,using Doctrine (if you need to query a database), and more!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Big 👍 (except that we don't use serial comma's like the one before "and more!")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Noted 😉 I'm going to modify the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍 That's indeed much better.
wouterj commentedAug 22, 2015
👍 |
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes#5635).Discussion----------Fix minor problems in book/page_creation.rst| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | >= 2.6| Fixed tickets | N/ACommits-------5a4a51b Fix minor problems in book/page_creation.rst
xabbuh commentedAug 22, 2015
Thank you@fabschurt. I have merged your patch into the |
fabschurt commentedAug 22, 2015
Sure, actually I had branched from |