Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Quick review of 'create framework' tutorial#5570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
weaverryan merged 3 commits intosymfony:2.3fromwouterj:create_Fraemwork_fixes
Dec 23, 2015

Conversation

@wouterj
Copy link
Member

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not sure if the new version is much better than the old one. The repeatedinstead of is confusing to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I tweaked this here to avoid the 2instead of - sha:3640b2a

@xabbuh
Copy link
Member

You could also add the missing use statement for the HttpKernel component (see#5556 (comment)).

@wouterj
Copy link
MemberAuthor

That was the original reason for doing this PR, but it turns out it isn't missing. It's included in a previous chapter or code example.

@xabbuh
Copy link
Member

I see, but then we should imo add// ... placeholders where they are needed in that file.

@wouterj
Copy link
MemberAuthor

Then we need to do it for 99% of the examples (as it's a tutorial, all code examples are an improvement of the previous shown example)

@xabbuh
Copy link
Member

Hm, you're right. I think we can keep it as is then.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest using a newer version than 4.1, which is EOLed

@wouterj
Copy link
MemberAuthor

PR updated and ready imo

@weaverryan
Copy link
Member

Thanks Wouter! The only thing I wonder about (and it was done this way before), is if we're going to use full namespaces for classes instead of use statements, why not prefix them with their opening \ so that they'll work even if someone copies some of this code into a namespaced file. What do you think about that?

@weaverryanweaverryan merged commit3f8e61d intosymfony:2.3Dec 23, 2015
weaverryan added a commit that referenced this pull requestDec 23, 2015
This PR was merged into the 2.3 branch.Discussion----------Quick review of 'create framework' tutorialCommits-------3f8e61d Apply suggestions from the comments613d6bc Use underscores in file nameece717e Quick review of 'create framework' tutorial
weaverryan added a commit that referenced this pull requestDec 23, 2015
@wouterjwouterj deleted the create_Fraemwork_fixes branchDecember 23, 2015 14:50
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@wouterj@xabbuh@weaverryan@javiereguiluz@stof@OskarStark

[8]ページ先頭

©2009-2025 Movatter.jp