Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Quick review of 'create framework' tutorial#5570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not sure if the new version is much better than the old one. The repeatedinstead of is confusing to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I tweaked this here to avoid the 2instead of - sha:3640b2a
xabbuh commentedJul 28, 2015
You could also add the missing use statement for the HttpKernel component (see#5556 (comment)). |
wouterj commentedJul 28, 2015
That was the original reason for doing this PR, but it turns out it isn't missing. It's included in a previous chapter or code example. |
xabbuh commentedJul 28, 2015
I see, but then we should imo add |
wouterj commentedJul 28, 2015
Then we need to do it for 99% of the examples (as it's a tutorial, all code examples are an improvement of the previous shown example) |
xabbuh commentedJul 29, 2015
Hm, you're right. I think we can keep it as is then. |
create_framework/unit_testing.rst Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest using a newer version than 4.1, which is EOLed
d8ae2f9 to3f8e61dComparewouterj commentedDec 19, 2015
PR updated and ready imo |
weaverryan commentedDec 23, 2015
Thanks Wouter! The only thing I wonder about (and it was done this way before), is if we're going to use full namespaces for classes instead of use statements, why not prefix them with their opening \ so that they'll work even if someone copies some of this code into a namespaced file. What do you think about that? |
No description provided.