symfony/symfony-docsPublic

NotificationsYou must be signed in to change notification settings
Fork5.3k
Star2.3k

[Create Framework] Fix extract calls (replaces #5522)#5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

wouterj merged 1 commit intosymfony:2.3fromwouterj:kenjis-patch-2

Jul 28, 2015

Merged

[Create Framework] Fix extract calls (replaces #5522)#5568

wouterj merged 1 commit intosymfony:2.3fromwouterj:kenjis-patch-2

Jul 28, 2015

Conversation

Copy link

Member

wouterj commentedJul 28, 2015

No description provided.

Fix code

a9d75c6

wouterj added the Status: Reviewed label

Jul 28, 2015

wouterj mentioned this pull request

Jul 28, 2015

[create_framework] Add missing extract() 2nd arg#5522

Merged

wouterj merged commita9d75c6 intosymfony:2.3

Jul 28, 2015

wouterj added a commit that referenced this pull request

Jul 28, 2015

minor#5568[Create Framework] Fix extract calls (replaces#5522) (ke…

29c80ce

…njis)This PR was merged into the 2.3 branch.Discussion----------[Create Framework] Fix extract calls (replaces#5522)Commits-------a9d75c6 Fix code

wouterj deleted the kenjis-patch-2 branch

July 28, 2015 13:27

Copy link

Member

stof commentedAug 1, 2015

This could still overwrite the$request variable, which would change what the template would receive

xabbuh mentioned this pull request

Aug 4, 2015

[CreateFramework] don't override existing variables#5597

Merged

Copy link

Member

xabbuh commentedAug 4, 2015

see#5597

wouterj added a commit that referenced this pull request

Aug 20, 2015

minor#5597[CreateFramework] don't override existing variables (xabbuh)

c0676f3

This PR was merged into the 2.3 branch.Discussion----------[CreateFramework] don't override existing variables| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#5568When extracting the request attributes, existing variables must not beoverridden so that the `$request` variable is passed to the template asis.Commits-------4b23fdc don't override existing variables