Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change Sql Field name because it's reserved#5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
wouterj merged 1 commit intosymfony:2.3fromrmed19:change_sql_field_name
Jul 28, 2015

Conversation

@rmed19
Copy link
Contributor

QA
Doc fix?yes
New docs?no
Applies to2.3+
Fixed tickets#5566

@javiereguiluz
Copy link
Member

@rmed19 👍 for changing the name. However, I'd like to propose a different new name. What if we usecreated_at name, which is more common for PHP applications? In any case, please don't change anything until we have the opinion of the documentation managers. Thanks.

@wouterj
Copy link
Member

👍

@wouterjwouterj merged commit5daa5f8 intosymfony:2.3Jul 28, 2015
wouterj added a commit that referenced this pull requestJul 28, 2015
This PR was merged into the 2.3 branch.Discussion----------Change Sql Field name because it's reserved| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | 2.3+| Fixed tickets |#5566Commits-------5daa5f8 Change Sql Field name because it's reserved
wouterj added a commit that referenced this pull requestJul 28, 2015
This seems to be more common.
@wouterj
Copy link
Member

Thank you@rmed19 for catching this error. Congratz on your first ever doc contribution! You'll receive the doc contributor badge within some days.

I've renamed the column tocreated_at, as proposed by@javiereguiluz in0134123 after merging your PR. If you don't agree with this change, feel free to comment.

@rmed19
Copy link
ContributorAuthor

Yes, created_at is more common, so it's will be better to change created_date to it

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rmed19@javiereguiluz@wouterj
[8]ページ先頭
©2009-2025 Movatter.jp