Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Fix typo Esi in part create framework#5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
OskarStark commentedJul 23, 2015
👍 you are right <?php/* * This file is part of the Symfony package. * * (c) Fabien Potencier <fabien@symfony.com> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */namespaceSymfony\Component\HttpKernel\HttpCache;useSymfony\Component\HttpFoundation\Request;useSymfony\Component\HttpFoundation\Response;useSymfony\Component\HttpKernel\HttpKernelInterface;/** * Esi implements the ESI capabilities to Request and Response instances. * * For more information, read the following W3C notes: * * * ESI Language Specification 1.0 (http://www.w3.org/TR/esi-lang) * * * Edge Architecture Specification (http://www.w3.org/TR/edge-arch) * * @author Fabien Potencier <fabien@symfony.com> */class Esiimplements SurrogateInterface{private$contentTypes;... |
weaverryan commentedJul 23, 2015
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Shouldn't we also fix the namespace (theSymfony\Component part is missing and there is nouse statement for it)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
let's merge this PR as-is
wouterj commentedJul 28, 2015
Wow, this error isn't even discovered by PHP, but you found it and fixed it. Thanks! |
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#5556).Discussion----------Fix typo Esi in part create framework| Q | A| ------------- | ---| Doc fix? | yes| New docs? | no| Applies to | all| Fixed tickets |Name for Esi class was wrong : ESI -> EsiCommits-------43e06c3 Fix typo Esi in part create framework
Name for Esi class was wrong : ESI -> Esi