Removed reference to remove HTTPS off from nginx configuration#5536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

xabbuh merged 1 commit intosymfony:2.3fromwjzijderveld:dont-disable-https-for-nginx

Jul 23, 2015

Merged

Removed reference to remove HTTPS off from nginx configuration#5536

xabbuh merged 1 commit intosymfony:2.3fromwjzijderveld:dont-disable-https-for-nginx

Jul 23, 2015

Conversation

Copy link

Contributor

wjzijderveld commentedJul 16, 2015

Q	A
Doc fix?	yes
New docs?	no
Applies to	all
Fixed tickets	#5517

As explained and confirmed in#5517 thehttps off flag could be causing issues, in my opinion it's better to rely on the defaults distributions give.

An alternative would be to replace the lines withHTTPS $https;,nginx will fill $https depending on current request. But I think it's less confusing if we just let the lines out of the example.

Removed reference to remove HTTPS off from nginx configuration

3878e14

Copy link

othillo commentedJul 16, 2015

👍

1 similar comment

Copy link

Member

weaverryan commentedJul 23, 2015

👍

Copy link

Member

xabbuh commentedJul 23, 2015

Thank you@wjzijderveld.

xabbuh merged commit3878e14 intosymfony:2.3

Jul 23, 2015

xabbuh added a commit that referenced this pull request

Jul 23, 2015

minor#5536Removed reference to remove HTTPS off from nginx configur…

10cb3ed

…ation (wjzijderveld)This PR was merged into the 2.3 branch.Discussion----------Removed reference to remove HTTPS off from nginx configuration| Q             | A| ------------- | ---| Doc fix?      | yes| New docs?     | no| Applies to    | all| Fixed tickets |#5517As explained and confirmed in#5517 the `https off` flag could be causing issues, in my opinion it's better to rely on the defaults distributions give.An alternative would be to replace the lines with `HTTPS $https;`, [nginx will fill $https depending on current request](http://nginx.org/en/docs/http/ngx_http_core_module.html#var_https). But I think it's less confusing if we just let the lines out of the example.Commits-------3878e14 Removed reference to remove HTTPS off from nginx configuration

wachterjohannes pushed a commit to sulu/docs that referenced this pull request

Aug 18, 2016