Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
[create_framework] Add missing extract() 2nd arg#5522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedJul 15, 2015
@kenjis 👍 thanks for reporting this error. I can confirm this is an error. Inthe original article at Fabien's website, the |
xabbuh commentedJul 15, 2015
@javiereguiluz The page that@kenjis changed is actualpart 6, but I agree that it should be fixed here (using |
xabbuh commentedJul 15, 2015
Hm, actually I think it's right to not specify an argument here. The reason this was done in the previos chapters is that the default behaviour of |
kenjis commentedJul 15, 2015
@xabbuh the |
xabbuh commentedJul 15, 2015
@kenjis Yeah, I agree that it should simply be removed on the previous page. |
wouterj commentedJul 28, 2015
wouterj commentedAug 20, 2015
Good news! We decided to add this argument to the other examples again, as it prevents overriding the |
This PR was merged into the 2.3 branch.Discussion----------[create_framework] Add missing extract() 2nd argSee previous page:http://symfony.com/doc/2.3/create_framework/templating.htmlThe code is `extract($request->attributes->all(), EXTR_SKIP);`.In this page, suddenly `EXTR_SKIP` is missing. I don't know why.Commits-------0905395 Fix code
kenjis commentedAug 20, 2015
My pleasure. |

See previous page:http://symfony.com/doc/2.3/create_framework/templating.html
The code is
extract($request->attributes->all(), EXTR_SKIP);.In this page, suddenly
EXTR_SKIPis missing. I don't know why.