Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.3k
Cookbook entry: Asset - Custom Version Strategy#5489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Cookbook entry: Asset - Custom Version Strategy#5489
Uh oh!
There was an error while loading.Please reload this page.
Conversation
teohhanhui commentedJul 5, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | 2.7+ |
| Fixed tickets | #4982 |
94bd6ba tob5f5b71Compare1c48a83 to79564d2CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
which package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
That's an empty string. I should make that clearer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you!
OskarStark commentedJul 16, 2015
great job@teohhanhui |
79564d2 to4daa0f9CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'd like to reword this paragraph. Instead of saying: "Symfony has some options to tweak things" ... we could say something like: "Symfony uses by default the XXX asset versioning strategy. Its behavior can be controlled with the xxx and yyy configuration options".
javiereguiluz commentedJul 17, 2015
@teohhanhui thanks for writing this article. I like it a lot because I didn't know how to define your own asset versioning strategy 👍 |
4daa0f9 to8d71390Compareteohhanhui commentedJul 23, 2015
Anything else that you need me to change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
you could put this "Note" in a note block
cb1c157 to254ddacCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"use" must be capitalised
254ddac to2f8f74bCompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is wrong. Your XML config is passing a single argument to BusterVersionStrategy which is an array with 2 elements, which does not match at all the config in other formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
hmm no sorry. It does match them. I looked at it too fast. However, I don't think passing an array of option is worth it. Just configure things with normal arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since PHP doesn't have named arguments, it's rather unfortunate that things become unrecognizable soon when you no longer know what's what.
2f8f74b tob770f79Compareteohhanhui commentedAug 11, 2015
Are we good yet? |
OskarStark commentedAug 11, 2015
i would say: yes |
xabbuh commentedAug 17, 2015
Wow, I really like this article! 👍 However, I think we should just move some contents around to show a more straight-forward implementation. What I have in mind to have short introduction which list the required steps:
I also think we should not focus on the default package. We can make the compiler pass generic and pass the package name as an argument to the constructor (we could just use the default package name in our example and add a sidebar which adds a short explanation about packages in general and the default package here). What do you think? |
teohhanhui commentedAug 18, 2015
Sidebar? |
xabbuh commentedAug 18, 2015
@teohhanhui You can use a ..sidebar::sidebar title sidebar contents Technically, it will not be rendered as a sidebar on symfony.com, but more like an additional note. |
xabbuh commentedMay 21, 2016
@teohhanhui Are you able to finish this one? :) |
| return $versionized; | ||
| } | ||
| private function loadManifest(array $options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
$options is never used, should be removed.
But great work on this cookbook article! Is exactly what I was looking for.
teohhanhui commentedJun 23, 2016
@xabbuh Will try... |
javiereguiluz commentedNov 15, 2016
Closing it in favor of#7141, which finishes this great article. Thanks@teohhanhui for your work. I've reused your original commits, so you'll get full credit for your work. |
…teohhanhui, javiereguiluz)This PR was merged into the 2.7 branch.Discussion----------Added "How to Use a Custom Version Strategy for Assets"This PR finishes the great work made by@teohhanhui in#5489.Commits-------1399967 Fixed a label name981e82d Misc fixesa02f3b3 Added the version_strategy option to the config reference2830ba0 Added the missing doc label482fda5 Minor rewords and fixesf038483 Removed an unneeded changeab8fa54 Fixed a rebase errorc59cff6 Moved the article to its new location5971ce0 Removed an unneeded file40dff64 Minor updates to the doc and service config80d0ca2 Simplified the intro4f530d8 Cookbook entry: Asset - Custom Version Strategy
… (xabbuh)This PR was merged into the 3.1 branch.Discussion----------Added "How to Use a Custom Version Strategy for Assets"Another attempt to finish@teohhanhui's great work from#5489.This willfix#6205.Commits-------d3308be Added "How to Use a Custom Version Strategy for Assets"