Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[RFC] remove duplicated explanation#5482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
DQNEO wants to merge2 commits intosymfony:2.7fromDQNEO:remove_duplicated_installation_document
Closed

[RFC] remove duplicated explanation#5482

DQNEO wants to merge2 commits intosymfony:2.7fromDQNEO:remove_duplicated_installation_document

Conversation

DQNEO
Copy link
Contributor

First, thank you very much for your great effort to maintain this documentation.

I am one of Symfony newbies, and I felt reading documentation is a little bit difficult.
One of the reasons is that there is some duplication of explanations.

I know this PR is a kind of controversial one, but removing duplication would make less confusion for new comers.


QA
Doc fix?yes
New docs?no
Applies toSymfony 2.7
Fixed ticketsnone

$ php app/console server:stop

.. tip::
See the Installtion Manual. :doc:`/book/installtion`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor typo: :doc:/book/installtion --> :doc:/book/installation

@DQNEO
Copy link
ContributorAuthor

@jackdelin thank you, fixed it.

@DQNEODQNEO changed the titleremove duplicated explanation[RFC] remove duplicated explanationJul 5, 2015
@javiereguiluz
Copy link
Member

@DQNEO I love this pull request. This "deduplication" is really the right thing to do and it will simplify the work of our doc managers. I've created a new pull request (#5497) to reword the text that explains where to look for the Symfony installation help. Of course I took your original commits from this pull request, so you won't lose the credit of your work. Thanks!

@xabbuh
Copy link
Member

@DQNEO@javiereguiluz Do you suggest to close here in favor of#5497 or do you like to discuss both things separately?

@DQNEODQNEO closed thisJul 8, 2015
@DQNEO
Copy link
ContributorAuthor

I closed this one.

@DQNEODQNEO deleted the remove_duplicated_installation_document branchJuly 8, 2015 00:05
@DQNEO
Copy link
ContributorAuthor

We made it!
d043b62

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DQNEO@javiereguiluz@xabbuh

[8]ページ先頭

©2009-2025 Movatter.jp