Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added a tip about hashing the result of nextBytes()#5472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
javiereguiluz commentedJul 2, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | #4328 |
This little contribution needs some review. Thanks! |
| The ``nextBytes()`` method returns a binary string which may contain the | ||
| ``\0`` character. If you store this value in a database or include it as | ||
| part of the URL, make sure to hash the value returned by ``nextBytes()`` | ||
| (to do that, you can use a simple ``md5()`` PHP function). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Not sure if we should limit the tip to these two scenarios. There could be lots of third-party systems you need so send data to which may or may not be capable of handling strings containing the null byte. Could we/should we write this more generic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I agree. I've reworded this tip. Thanks.
👍 |
…viereguiluz)This PR was merged into the 2.3 branch.Discussion----------Added a tip about hashing the result of nextBytes()| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | all| Fixed tickets |#4328Commits-------1a4b5fa Reword64460d5 Added a tip about hashing the result of nextBytes()
Awesome! Minor tweaks at sha:6a34332 |
* 2.3: [#5472] Minor tweak and adding code example Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
* 2.6: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
* 2.7: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix caching Fix build Added a tip about hashing the result of nextBytes() rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Improve travis build speed
* 2.8: [#5472] Minor tweak and adding code example [#5453] Minor tweaks - mostly thanks to Javier Reword Fix moving the mapped down as per@xabbuh Fix caching Fix build Fix the rendering issue Fix issues reported by@snoek09 . Thank you. Added a tip about hashing the result of nextBytes() Make the necessary changes mentioned by@xabbuh and add example for form rework the quick tour's big picture fix for Symfony 2.7 Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Starting with range documentation Improve travis build speed