Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Integrate the "Create your own framework" tutorial#5424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Commits-------8ed4076 Fixed typoDiscussion----------Fixed typo
Commits-------b239305 Fixed typoDiscussion----------Fixed typo
Commits-------fcaf268 Fixes grammatical errorDiscussion----------Fixes grammatical error
Commits-------4c2e4f9 [part2] Fixinng typo: removing one of the double whereDiscussion----------[part2] Typo "where where"Fixing typo: removing one of the double where.
Commits-------95edc8d Add missing colon to code-blockDiscussion----------Missing colonAdd missing colon to code-block
…ut some people copy/paste this line too
Commits-------a18f827 fixed typosDiscussion----------fixed typos
If $request is not typed there is an error : Controller "render_template" requires that you provide a value for the "$request" argument (because there is no default value or because there is a non optional argument after this one).
This PR was merged into the master branch.Discussion----------Update part06.rstIf $request is not typed there is an error : Controller "render_template" requires that you provide a value for the "$request" argument (because there is no default value or because there is a non optional argument after this one).Commits-------a1336e0 Update part06.rst
I agree that changing the we to you would be great, but merging this PR fast would be even better. There is quite a lof of traffic on this tutorial on my blog and as it becomes more outdated by the day, I would really like to redirect people in the official Symfony docs instead. |
I would be fine with merging this in the short-term if we could get rid of the numbers in the filenames. That way we could later discuss if the structure will stay the same or if we need/want to split contents further without having weird/misleading URLs (the FOSRestBundle had something similar recently when splitting a chapter). |
@xabbuh I've just removed the numbers from the file names. I'm also willing to do any other big change that you consider necessary before merging this tutorial (except for the mentioned |
@javiereguiluz Seems that some internal references need to be updated too. |
I agree about merging this. However, changing we -> you should still be done as a separate PR to keep consistency in the doc. So if you don't do it yourselves, please open an issue to tell people about it. |
@weaverryan@wouterj What do you think about merging this as is and tweak in subsequent pull requests? |
Let's do it :) |
dupuchba commentedJul 2, 2015
That's really cool :-) 👍 |
👍 - I've merged it in. It's way too big anyways to get perfect - so now let's see all those small changes :). Thanks! |
weaverryan added a commit that referenced this pull requestJul 2, 2015
…pot, lyrixx, jdreesen, catchamonkey, gnugat, andreia, Arnaud Kleinpeter, willdurand, amitayh, nanocom, hrbonz, Pedro Gimenez, ubick, dirkaholic, bamarni, revollat, javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Integrate the "Create your own framework" tutorialThis is a follow-up of the stalled#4455 PR. I've made most, but not all, of the changes proposed by reviewers.Specifically, I haven't changed the occurrences of `we` by `you`. The reason is that it's too much work. The original PR (submitted 8 months ago) died for that reason. So here it is my question: could we bypass the `we -> you` changes to merge it as soon as possible and fix that in further pull requests?Commits-------bca9bae Updated doc references in the map.rst.inc file108f109 Removed the numbers from the file namesdb9fa43 Made a lot of improvements suggested by reviewers126bcef removed external references alignement13a7170 made some changes to better integrate the tutorial into the current documentationbf9c871 fixed markupd44e4a2 added the new tutorial in the main index73cd243 added the "Create your own framework" tutorial409dba5 move things aroundf303b20 removed versions when adding Symfony component with Composer55f5c12 updated the whole book (changes mainly related to Composer)842e4d1 bug#25 Update part06.rst (revollat)a1336e0 Update part06.rstd802d42 updated code for Symfony 2.3 and made minor tweaks to the textf3c151c reworded slightly some sentence to convert the text from a series of articles to a bookca9d5d8 removed unused references249b704 added missing linksf6656e4 removed a note that is not relevant anymore10e2732 added an index filec88c20a removed usage of the ClassLoader component in favor of Composer2ddd8b9 merged branch bamarni/master (PR#24)799e963 updated composer autoload path91e46f6 removed the paragraph about CS as we now have standards43e2e35 Merge pull request#23 from dirkaholic/master6e01599 Fix little typoe8c19f7 Merge pull request#22 from ubick/master8e7106d Fixed a typo in part02.rst (<php changed to <?php)c087780 merged branch amitayh/master (PR#17)0d6beb1 merged branch pedrotgimenez/part11 (PR#21)60617d7 Fixed one typo.aae0705 fixed CS9533f9a merged branch hrbonz/part12_fixes (PR#19)d0ff8bc updated titles400c087 add framework code as people would probably modify it following first code example (putting object creations in src/Simplex/Framework.php)de69a87 HttpKernel name can't be imported twice, if importing only Symfony\Component\HttpKernel\HttpKernel there will be problems later with HttpKernel subclasses (HttpKernel\Controller\ControllerResolver first and the others following). Could use 'use ... as ...' but I don't like it.006b1e2 fixed markup1f43dbf removed conflict merge0941f47 merged branch Nanocom/master (PR#18)d907d46 Fixed typosdb59374 fixed typo11886e6 Merge branch 'master' ofhttps://github.com/amitayh/Create-Your-Frameworka8a2da0 Fixed part 12 typos26bef8d Fixed typos9bc692f added part 120b7581d merged branch willdurand/patch-1 (PR#16)16b5b09 Fixed typo831adec merged branch Nanocom/master (PR#15)a3f0b31 Corrected few typosae1171a merged branch jdreesen/patch-3 (PR#10)7a8e449 merged branch Nanocom/master (PR#14)09969d9 added part 1176e45f9 fixed markupfda9900 fixed pygments code name for json02aab54 Corrected some english errors8399581 moved the Context::fromRequest() code to the Framework class111cac0 removed some use statement to be more consistent with previous partsa635d89 added part 10bde64c8 made small tweaks54e1b08 added a note in part 8f00401d added part 85674395 renamed part as we now know that we are going to have more than 10 parts479a85e fixed typosa0b1d42 merged branch gnugat/part7-typo-simple (PR#12)9ffd186 [part7] Fixing typo: adding 'x' to Simple/Framework class97743fb added part 7fdb195c added part 60ce2a83 fixed some typosdb0ad14 added part 5bd3ca8e fixed extract() calls7e8da09 fixed typo (closes#8)1473eec fixed typo358b4c8 added part 4255577f went back to 2.1.* in composer.json files3d46b1d merged branch jdreesen/patch-2 (PR#7)a18f827 fixed typos18d376e updated composer.json26be81c added part 34b39fc0 removed the path to composer.json as JSON doe snot support comments but some people copy/paste this line too00e524e fixed ambiguity (closes#6)6fe23c0 merged branch andreia/master (PR#5)95edc8d Add missing colon to code-block7e5cd41 merged branch gnugat/part2-typo-where-where (PR#4)4c2e4f9 [part2] Fixinng typo: removing one of the double whereee67eee fixed markup94db3cb merged branch catchamonkey/patch-1 (PR#3)a4f52d9 added links to projectsfcaf268 Fixes grammatical error2c79d42 added part 213ba87c added a tip about the Composer autoloaderb93c118 merged branch jdreesen/patch-1 (PR#2)269c6ce merged branch lyrixx/patch-1 (PR#1)b239305 Fixed typo8ed4076 Fixed typo99c5c08 added a LICENSE file0ef3f8e added part 1
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of the stalled#4455 PR. I've made most, but not all, of the changes proposed by reviewers.
Specifically, I haven't changed the occurrences of
webyyou. The reason is that it's too much work. The original PR (submitted 8 months ago) died for that reason. So here it is my question: could we bypass thewe -> youchanges to merge it as soon as possible and fix that in further pull requests?