Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork5.2k
Added mentions to some popular (and useful) Symfony bundles#5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
javiereguiluz commentedJun 9, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes |
| Applies to | all |
| Fixed tickets | - |
| .. tip:: | ||
| If your application logs in users via a third-party service such as Google, | ||
| Facebook or Twitter, check out the `HWIOAuthBundle`_ community bundle. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this bundle is abotu OAuth authentication. this is not specific to Twitter, Facebook or Google only. The wording should be improved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I disagree. I think that mentioning Google, Facebook and Twitter explicitly is the best way to explain the purpose of this bundle.
| Instead of handling file uploading yourself, you may consider using the | ||
| `VichUploaderBundle`_ community bundle. This bundle provides all the common | ||
| operations (such as file renaming, saving and deleting) and it's tightly | ||
| integratd with Doctrine ORm, ODM, PHPCR ODM and Propel. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
typo:integrated.
AndORM should be all uppercase.
AndODM should be replaced byMongoDB ODM (there are several Doctrine ODMs)
| @@ -275,6 +275,11 @@ But who can you login as? Where do users come from? | |||
| What other methods are supported? See the :doc:`Configuration Reference </reference/configuration/security>` | |||
| or :doc:`build your own </cookbook/security/custom_authentication_provider>`. | |||
| .. tip:: | |||
| If your application logs in users via a third-party service such as Google, | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[...] logs users in [...]
weaverryan added a commit that referenced this pull requestJun 19, 2015
…dles (javiereguiluz)This PR was merged into the 2.3 branch.Discussion----------Added mentions to some popular (and useful) Symfony bundles| Q | A| ------------- | ---| Doc fix? | no| New docs? | yes| Applies to | all| Fixed tickets | -Commits-------9dc8b8f Fixed a minor grammar issue7370433 Fixed typosbf4f3d6 Link to the official repository of the bundle.963d0a6 Added mentions to some popular (and useful) Symfony bundles
weaverryan added a commit that referenced this pull requestJun 19, 2015
Such an easy win - thanks Javier! I tweaked the one note slightly at sha:c7ec621 per Stof's comment. |
weaverryan added a commit that referenced this pull requestJun 19, 2015
* 2.3: [#5373] Small tweak per Stof's comment Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Constraints - empty strings and null values Add a caution to the getUploadRootDir - correction Adding a caution to the getUploadRootDir() method [#4228] Moved requiring files to definitions
weaverryan added a commit that referenced this pull requestJun 19, 2015
* 2.6: [#5373] Small tweak per Stof's comment Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Constraints - empty strings and null values Add a caution to the getUploadRootDir - correction Adding a caution to the getUploadRootDir() method [#4228] Moved requiring files to definitions
weaverryan added a commit that referenced this pull requestJun 19, 2015
* 2.7: (23 commits) [#5331] Tiny typo [#5373] Small tweak per Stof's comment [PSR-7] Bridge documentation Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Updated the list of reserved domains and the URL reference Use the reserved domains example.com and example.org Constraints - empty strings and null values ...
weaverryan added a commit that referenced this pull requestJun 19, 2015
* 2.8: (24 commits) [#5331] Tiny typo [#5373] Small tweak per Stof's comment Added depreciation note for the cascade_validation constraint and updated position of depreciation notes [PSR-7] Bridge documentation Fix after install URL and new photo since AcmeDemoBundle is not part of 2.7 Fixed a minor grammar issue Fixed typos Link to the official repository of the bundle. Added mentions to some popular (and useful) Symfony bundles [#5095] Fixing a typo and updating to a more realistic example [Components][ClassLoader] remove DebugClassLoader [#4228] Move synthetic services to its own recipe clarify bundle installation instructions Implemented the suggestions made by Christian and Wouter Replace phpDocumentor by the standard PHPDoc Implemented the changes suggested by reviewers Fixed an internal link reference Reviewed the Bundles cookbook articles Updated the list of reserved domains and the URL reference Use the reserved domains example.com and example.org ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.